You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/11/25 22:22:53 UTC

[GitHub] [libcloud] macfreek opened a new issue #1523: RecordType.URL should be RecordType.URI

macfreek opened a new issue #1523:
URL: https://github.com/apache/libcloud/issues/1523


   ## Summary
   
   `libcloud.dns.types` defines a RecordType 'URL'. However, no such RR Type exists in DNS. Likely, this is supposed to refer to the 'URI' RR Type.
   
   ## Detailed Information
   
   The authoritative list of DNS RR types is https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml. There is no 'URL' RR type in this list. There is a 'URI' RR type in this list, as defined in [RFC 7553](https://tools.ietf.org/html/rfc7553)
   
   This RecordType is defined in 4 places in libcloud:
   
   [libcloud.dns.types, line 112](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/types.py#L112):
   ```
       URL = 'URL'
   ```
   
   [libcloud.dns.drivers.cloudflare, line 171](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/cloudflare.py#L171): [sic!]
   ```
           RecordType.URL: 'LOC'
   ```
   
   [libcloud.dns.drivers.dnsimple, line 57](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/dnsimple.py#L57)
   ```
           RecordType.URL: 'URL',
   ```
   
   [`libcloud.dns.drivers.zerigo`, line 142](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/zerigo.py#L142)
   ```
           RecordType.URL: 'URL',
   ```
   
   My recommendation is to change these occurrences into `'URI'`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [libcloud] stale[bot] commented on issue #1523: RecordType.URL should be RecordType.URI

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #1523:
URL: https://github.com/apache/libcloud/issues/1523#issuecomment-868936533


   Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org