You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Marton Elek (Jira)" <ji...@apache.org> on 2019/12/04 13:23:00 UTC

[jira] [Created] (HDDS-2661) Use field based Config annotation instead of method based

Marton Elek created HDDS-2661:
---------------------------------

             Summary: Use field based Config annotation instead of method based
                 Key: HDDS-2661
                 URL: https://issues.apache.org/jira/browse/HDDS-2661
             Project: Hadoop Distributed Data Store
          Issue Type: Improvement
            Reporter: Marton Elek


HDDS-2413 proposes an additional usage of the @Config annotation: to set configuration based on an existing configuration class.

But as of now we annotate the setters instead of the fields. To avoid annotation duplication (we need to read the values from the getters or the fields) I propose to switch to use field based annotations instead of setter based annotation.

I think it's more readable and additional validation (even the class level validations) can be done in a @PostConstruct method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org