You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Jose Juan Montiel (JIRA)" <ji...@apache.org> on 2012/04/24 11:57:34 UTC
[jira] [Created] (VFS-412) Support to send execPROT("P")
Jose Juan Montiel created VFS-412:
-------------------------------------
Summary: Support to send execPROT("P")
Key: VFS-412
URL: https://issues.apache.org/jira/browse/VFS-412
Project: Commons VFS
Issue Type: Improvement
Reporter: Jose Juan Montiel
Priority: Minor
Attachments: patch_exexprot.txt
The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
522 Data connections must be encrypted.
The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) Support to send execPROT("P")
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261992#comment-13261992 ]
Gary D. Gregory commented on VFS-412:
-------------------------------------
I am looked at this patch but I am running into some problems testing it. The test you submitted does not run with the build, it appears fits in the framework that assumes you manually manage an external server. I am working on a test that manages an embedded server just like for the FTP test. But... the test fails because is hangs when trying to read from more than one stream at a time. This is not an issue with plain FTP though, both FTP and FTPS use Commons Net at the wire level. Stay tuned to JIRA and the ML for more...
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-412) [FTPS] Support to send execPROT("P")
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory updated VFS-412:
--------------------------------
Attachment: AFO-generics.diff
> [FTPS] Support to send execPROT("P")
> ------------------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: AFO-generics.diff, patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-412) Support to send execPROT("P")
Posted by "Jose Juan Montiel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jose Juan Montiel updated VFS-412:
----------------------------------
Attachment: patch_exexprot.txt
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-412) [FTPS] Support to send execPROT("P")
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory updated VFS-412:
--------------------------------
Attachment: (was: AFO-generics.diff)
> [FTPS] Support to send execPROT("P")
> ------------------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) Support to send execPROT("P")
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278451#comment-13278451 ]
Gary D. Gregory commented on VFS-412:
-------------------------------------
I'll get back to this next week probably...
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) [FTPS] Support to send execPROT("P")
Posted by "Jose Juan Montiel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491564#comment-13491564 ]
Jose Juan Montiel commented on VFS-412:
---------------------------------------
Hi, i needed PROT setting because a test against VSFTPS with mode "explicit" enabled, becaus that command was required
Here the snipet of config file for VSFTPS server.
#
# Configuracion SSL
#
# Habilita el soporte de TLS/SSL
ssl_enable=YES
# Obliga a utilizar TLS/SSL para todas las operaciones
force_local_data_ssl=YES
force_local_logins_ssl=YES
# Se prefiere TLSv1 sobre SSLv2 y SSLv3
ssl_tlsv1=YES
ssl_sslv2=NO
ssl_sslv3=NO
# Solo para version 2.3.2
require_ssl_reuse=false
Acording other server filezilla (http://trac.filezilla-project.org/ticket/2581) maybe the mode explicit/implicit matter.. but on the other hand, i open this "jira" to add functionality (pass PROT to the client)... you talk about to pass another comamnd PBSZ (like this example http://www.kochnielsen.dk/kurt/blog/?p=162)...
For me only need the of PROT, but if Gary is going to committed to VFS 2.1-SNAPSHOT ;) i don't mind to add support to PBSZ in the same way...
> [FTPS] Support to send execPROT("P")
> ------------------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) [FTPS] Support to send execPROT("P")
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492002#comment-13492002 ]
Gary Gregory commented on VFS-412:
----------------------------------
Hello All and JJ:
In order to speed this up, could you please:
- resubmit the patch against the current trunk?
- make sure the build works with "mvn clean site"
- make sure the new code gets as close to 100% test coverage
Thank you!
Gary
> [FTPS] Support to send execPROT("P")
> ------------------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) Support to send execPROT("P")
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260475#comment-13260475 ]
Gary D. Gregory commented on VFS-412:
-------------------------------------
This patch cannot be considered because it was not granted license to the ASF. Granting is done in the patch submission dialog.
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) Support to send execPROT("P")
Posted by "Jose Juan Montiel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276826#comment-13276826 ]
Jose Juan Montiel commented on VFS-412:
---------------------------------------
Hi, can i help you with this?
I'll review test, i only try to make "similiar" to "FTP"...
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-412) Support to send execPROT("P")
Posted by "Jose Juan Montiel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jose Juan Montiel updated VFS-412:
----------------------------------
Attachment: patch_412.txt
I think i check "Grant license to ASF..." but i do it again.
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-412) [FTPS] Support to send execPROT("P")
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory updated VFS-412:
--------------------------------
Summary: [FTPS] Support to send execPROT("P") (was: Support to send execPROT("P"))
> [FTPS] Support to send execPROT("P")
> ------------------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) Support to send execPROT("P")
Posted by "Jose Juan Montiel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260437#comment-13260437 ]
Jose Juan Montiel commented on VFS-412:
---------------------------------------
In RunTest i misteke and put props.setProperty("test.ftp.uri".... should be "test.ftps.uri"...
> Support to send execPROT("P")
> -----------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-412) [FTPS] Support to send execPROT("P")
Posted by "Andreas Wallberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490309#comment-13490309 ]
Andreas Wallberg commented on VFS-412:
--------------------------------------
According to RFC 2228, (http://www.ietf.org/rfc/rfc2228.txt) that introduced PROT command, "The PBSZ command must be preceded by a successful security data exchange.". I think this means that "PBSZ 0" must be issued before "PROT P".
> [FTPS] Support to send execPROT("P")
> ------------------------------------
>
> Key: VFS-412
> URL: https://issues.apache.org/jira/browse/VFS-412
> Project: Commons VFS
> Issue Type: Improvement
> Reporter: Jose Juan Montiel
> Priority: Minor
> Labels: patch
> Attachments: patch_412.txt, patch_exexprot.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The layer over FTPSClient can't permit to send a client.execPROT("P") and this make in FTPS explicit (with vsFTPd 2.0.7) make an error:
> SSL version: TLSv1/SSLv3, SSL cipher: DES-CBC3-SHA, not reused, no cert
> 522 Data connections must be encrypted.
> The patch offer via FtpsFileSystemConfigBuilder the option to set execPROT like do with setPassiveMode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira