[GitHub] [hudi] codope commented on a diff in pull request #8275: [HUDI-5289] Avoiding repeated trigger of clustering dag

["codope (via GitHub)" <gi...@apache.org>]

codope commented on code in PR #8275:
URL: https://github.com/apache/hudi/pull/8275#discussion_r1147590832


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -255,6 +257,8 @@ protected HoodieWriteMetadata<HoodieData<WriteStatus>> executeClustering(HoodieC
         .performClustering(clusteringPlan, schema, instantTime);
     HoodieData<WriteStatus> writeStatusList = writeMetadata.getWriteStatuses();
     HoodieData<WriteStatus> statuses = updateIndex(writeStatusList, writeMetadata);
+    statuses.persist(config.getString(WRITE_STATUS_STORAGE_LEVEL_VALUE), context, HoodieData.HoodieDataCacheKey.of(config.getBasePath(), instantTime));

Review Comment:
   Good call and thanks for adding a test using `StageEventManager`. Could you create a JIRA to add more such tests. We need DAG tests to guard changes in DAG.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org