You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2006/12/14 12:48:11 UTC
DO NOT REPLY [Bug 41176] New: - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
Summary: Figure out what (if anything) we can do for PPT files
where the first SlideListWithTexts has slides and
masters
Product: POI
Version: 3.0-dev
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: HSLF
AssignedTo: poi-dev@jakarta.apache.org
ReportedBy: nick@torchbox.com
I've discovered that some PPT files (eg data/PictureTypeZero.ppt in SVN) have a
really crazy first SlideListWithText
In theory, there should be 2 or 3 of these. The first with MainMasters, the
second with Slides, and the optional third with Notes. However, on files like
these, the first one contains both MainMasters and Slides!
I've updated the code to throw a CorruptPowerPointFileException on these docs
(previously we had a class cast exception), but we need to figure out what (if
anything) we can do for them.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: DO NOT REPLY [Bug 41176] New: - Figure out what (if anything)
we can do for PPT files where the first SlideListWithTexts has slides and
masters
Posted by Nick Burch <ni...@torchbox.com>.
On Thu, 14 Dec 2006, Yegor Kozlov wrote:
> Who did create these ppt files? What software was used?
> Did it came from OpenOffice or saved as ppt in Adobe Illustrator or
> anything like this?
The one I've just added to svn, I found when I web spider I run broke on
the document...
It looks like the the sample ppt file uploaded with bug #40956 also
displays the same problem.
Erez - as the uploader of that file, do you know what software produced
it?
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: DO NOT REPLY [Bug 41176] New: - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by Yegor Kozlov <ye...@dinom.ru>.
Who did create these ppt files? What software was used?
Did it came from OpenOffice or saved as ppt in Adobe Illustrator or
anything like this?
I mean if we know the origin we can try to figure out why it happens.
Yegor
bao> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
bao> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
bao> <http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
bao> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
bao> INSERTED IN THE BUG DATABASE.
bao> http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
bao> Summary: Figure out what (if anything) we can do for PPT files
bao> where the first SlideListWithTexts has slides and
bao> masters
bao> Product: POI
bao> Version: 3.0-dev
bao> Platform: Other
bao> OS/Version: other
bao> Status: NEW
bao> Severity: normal
bao> Priority: P2
bao> Component: HSLF
bao> AssignedTo: poi-dev@jakarta.apache.org
bao> ReportedBy: nick@torchbox.com
bao> I've discovered that some PPT files (eg data/PictureTypeZero.ppt in SVN) have a
bao> really crazy first SlideListWithText
bao> In theory, there should be 2 or 3 of these. The first with MainMasters, the
bao> second with Slides, and the optional third with Notes. However, on files like
bao> these, the first one contains both MainMasters and Slides!
bao> I've updated the code to throw a CorruptPowerPointFileException on these docs
bao> (previously we had a class cast exception), but we need to figure out what (if
bao> anything) we can do for them.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
------- Additional Comments From nick@torchbox.com 2007-01-09 05:41 -------
So, if a PPT file has the first SLWT with
MainMaster
Slide
....
and the second SLWT with
Slide
Slide
Then all's fine, we ignore (for now) anything other than MainMaster in the first
SLWT, and grab the slides from the second one?
If we have a ppt with
MainMaster
Slide
....
and no second SLWT, we throw a CorruptPowerPointException?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
------- Additional Comments From gur@axismobile.com 2006-12-24 06:30 -------
Created an attachment (id=19303)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19303&action=view)
This file causes the exception
As requested - here is an example file that causes HSLF to throw the exception
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
------- Additional Comments From yegor@dinom.ru 2007-01-09 05:39 -------
Created an attachment (id=19381)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19381&action=view)
Improved SlideShow.buildSlidesAndNotes
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
------- Additional Comments From yegor@dinom.ru 2007-01-09 05:37 -------
Nick,
This is quite normal. The error happens when the first SLWT has a link to Title
Matster.
How to reproduce:
- open PowerPoint and create a presentation
- Menu view/slide master
- Menu Insert/ New Title Master. After it you should have two masters: a slide
master and a title master.
- save.
- Try to open it in HSLF and get the error.
I attached a sample file.
PowerPoint supports two types of slide masters:
* Slide Master. The data is in MainMaster container
* Title Master. The data is in Slide container. Weird? I think so.
I don't know why pages with title layout use different master. I guess if it is
missing the normal MainMaster
is used but I didn't research it yet.
I think your code in SlideShow.buildSlidesAndNotes has extra checks that can be
ommitted.
Just keep in mind, whatever you find in the fist SLWT it is about masters.
For now we handle only references to MainMasters. Later we will add support for
Title, Note and other masters.
I won't be surprised if we have references to other exotic containers in the
first SLWT.
See how I changed SlideShow.buildSlidesAndNotes.
Regards,
Yegor
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
------- Additional Comments From yegor@dinom.ru 2007-01-09 05:50 -------
>>Then all's fine, we ignore (for now) anything other than MainMaster in the first
>>SLWT, and grab the slides from the second one?
Yes. We always read master info from the first SLWT and slides from the second
one. Just ignore what we don't support.
>>If we have a ppt with
>> MainMaster
>> Slide
>> ....
>>and no second SLWT, we throw a CorruptPowerPointException?
Yes. There MUST be two SLWTs. If either is missing it means the ppt is corrupted
(or MS guys put another level of complexity into it :)).
Yegor
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
nick@torchbox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From nick@torchbox.com 2007-01-09 10:53 -------
OK, based on your findings (thanks for those!), I've applied your patch, and
then tidied the code up a little more (and made a few variables have more
sensible names)
Hopefully this scheme will be a good starting position for supporting future
kinds of masters.
I haven't got anything to throw CorruptPowerPoint in the case of not enough
SLWTs, do you think we should have that check?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 41176] - Figure out what (if anything) we can do for PPT files where the first SlideListWithTexts has slides and masters
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41176>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41176
------- Additional Comments From yegor@dinom.ru 2007-01-09 05:38 -------
Created an attachment (id=19380)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=19380&action=view)
ppt with title master
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/