You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/30 14:29:17 UTC
[GitHub] [camel] connormcauliffe-toast opened a new pull request #6008: Set pulsar redelivery count in exchange headers
connormcauliffe-toast opened a new pull request #6008:
URL: https://github.com/apache/camel/pull/6008
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
Pulsar tracks message redelivery to its consumers as field on the `Message`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6008: Set pulsar redelivery count in exchange headers
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6008:
URL: https://github.com/apache/camel/pull/6008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #6008: Set pulsar redelivery count in exchange headers
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #6008:
URL: https://github.com/apache/camel/pull/6008#discussion_r698541435
##########
File path: components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/utils/message/PulsarMessageHeaders.java
##########
@@ -31,4 +31,5 @@
String KEY_OUT = "CamelPulsarProducerMessageKey";
String PROPERTIES_OUT = "CamelPulsarProducerMessageProperties";
String EVENT_TIME_OUT = "CamelPulsarProducerMessageEventTime";
+ String PULSAR_REDELIVERY_COUNT = "pulsar_redelivery_count";
Review comment:
Please use the same Camel naming approach for the headers. Like for example CamelPulsarRedeliveryCount
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6008: Set pulsar redelivery count in exchange headers
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6008:
URL: https://github.com/apache/camel/pull/6008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #6008: Set pulsar redelivery count in exchange headers
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #6008:
URL: https://github.com/apache/camel/pull/6008#discussion_r698541435
##########
File path: components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/utils/message/PulsarMessageHeaders.java
##########
@@ -31,4 +31,5 @@
String KEY_OUT = "CamelPulsarProducerMessageKey";
String PROPERTIES_OUT = "CamelPulsarProducerMessageProperties";
String EVENT_TIME_OUT = "CamelPulsarProducerMessageEventTime";
+ String PULSAR_REDELIVERY_COUNT = "pulsar_redelivery_count";
Review comment:
Please use the same Camel naming approach for the headers. Like for example CamelPulsarRedeliveryCount
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org