[GitHub] ernjvr opened a new pull request #2836: Volume snapshot recurring schedule not showing

[GitBox <gi...@apache.org>]

ernjvr opened a new pull request #2836: Volume snapshot recurring schedule not showing
URL: https://github.com/apache/cloudstack/pull/2836
 
 
   
   
   ## Description
   <!--- Describe your changes in detail -->
   In the UI, when Setting up a recurring snapshot for a volume and clicking 'Add', the newly added scheduled snapshot entry is not displayed in the 'Scheduled Snapshots' table. Also, the 'Keep' input field does not limit the length of a number that can be added. This causes the API not return an error that the value is invalid.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   After adding a recurring snapshot, it must display in the 'Scheduled Snapshots' table. The 'Keep' input field must restrain a user from entering too large of a number.
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   
   <!-- Fixes: # -->
   Fixes: #2831
   ## Screenshots (if appropriate):
   ![image](https://user-images.githubusercontent.com/30108093/45089199-b5580000-b10b-11e8-8921-e8b4e324fd3b.png)
   ![image](https://user-images.githubusercontent.com/30108093/45089206-ba1cb400-b10b-11e8-8883-0b687403d0db.png)
   ![image](https://user-images.githubusercontent.com/30108093/45089213-bf79fe80-b10b-11e8-822a-962a357077c2.png)
   
   ## How Has This Been Tested?
   Manually
   <!-- Please describe in detail how you tested your changes. -->
   In the UI, click on the 'Instance' button. Click on an instance. Click the 'View Volumes' button. Click on a specific volume.  Click the 'Set up Recurring Snapshot' button.  Add a Recurring Snapshot and observe that it now does display the newly added schedule. Also when adding a 'Keep' number, it will limit the user to a maximum of 9 numbers.
   <!-- Include details of your testing environment, and the tests you ran to -->
   4.11
   KVM
   <!-- see how your change affects other areas of the code, etc. -->
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services