You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/08/17 10:10:57 UTC

Review Request 61710: Log Search UI: implement multiple options select for filters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61710/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-21740
    https://issues.apache.org/jira/browse/AMBARI-21740


Repository: ambari


Description
-------

User should be able to select several options of given filtering instance at once.


Diffs
-----

  ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts 0914864 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html b2ce3a0 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html b777b52 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts 029d87b 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html db4ee79 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less 0853883 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts 3e9a445 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts 2f8c969 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts c414782 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html d2de5e2 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts 4d6509b 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts 40e7d89 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html caae24e 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html f18285f 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts d1baedc 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 7715876 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts 028c10d 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 13a1e68 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts f79ba45 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 009b263 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts 985a0bf 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts a93eee5 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts 7180ebb 


Diff: https://reviews.apache.org/r/61710/diff/1/


Testing
-------

Executed 57 of 57 SUCCESS (1.367 secs / 1.345 secs)


Thanks,

Andrii Babiichuk


Re: Review Request 61710: Log Search UI: implement multiple options select for filters

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61710/#review183115
-----------------------------------------------------------


Ship it!




Ship It!

- Oleg Nechiporenko


On Aug. 17, 2017, 10:10 a.m., Andrii Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61710/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2017, 10:10 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-21740
>     https://issues.apache.org/jira/browse/AMBARI-21740
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> User should be able to select several options of given filtering instance at once.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts 0914864 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html b2ce3a0 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html b777b52 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts 029d87b 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html db4ee79 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less 0853883 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts 3e9a445 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts 2f8c969 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts c414782 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html d2de5e2 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts 4d6509b 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts 40e7d89 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html caae24e 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html f18285f 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts d1baedc 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 7715876 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts 028c10d 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 13a1e68 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts f79ba45 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 009b263 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts 985a0bf 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts a93eee5 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts 7180ebb 
> 
> 
> Diff: https://reviews.apache.org/r/61710/diff/1/
> 
> 
> Testing
> -------
> 
> Executed 57 of 57 SUCCESS (1.367 secs / 1.345 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>