You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/19 01:36:53 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #466: test: add basic headless service e2e test

tokers commented on a change in pull request #466:
URL: https://github.com/apache/apisix-ingress-controller/pull/466#discussion_r634854502



##########
File path: test/e2e/ingress/ingress.go
##########
@@ -226,3 +227,106 @@ spec:
 		_ = s.NewAPISIXClient().GET("/status/200").WithHeader("Host", "a.httpbin.org").Expect().Status(http.StatusNotFound)
 	})
 })
+
+var _ = ginkgo.Describe("support ingress.networking/v1 with headless service backend", func() {
+	s := scaffold.NewDefaultScaffold()
+
+	const _httpHeadlessService = `
+apiVersion: v1
+kind: Service
+metadata:
+  name: httpbin-headless-service-e2e-test
+spec:
+  selector:
+    app: httpbin-deployment-e2e-test
+  ports:
+    - name: http
+      port: 80
+      protocol: TCP
+      targetPort: 80
+  type: ClusterIP
+  clusterIP: None
+`
+
+	var backendSvc string
+	var backendPort []int32

Review comment:
       ```suggestion
   	var (
   		backendPort []int32
   		backendSvc string
   	)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org