You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/29 04:28:49 UTC
[GitHub] [superset] villebro edited a comment on issue #17238: [metrics control] Show error message when chart contains bad data
villebro edited a comment on issue #17238:
URL: https://github.com/apache/superset/issues/17238#issuecomment-954415090
If I understand this correctly, the real issue is the fact that we don't check which metrics are in use when attempting to delete them. To check this, we would need to add link table linking charts to metrics (and why not also calculated columns), similar to how we do between dashboards and charts or charts and datasets. Then we'd just check if the metric is referenced by charts when trying to delete it, similar to how we do when trying to delete a dataset that's referenced by charts:
I suspect the reason this hasn't been implemented is due to the dual Druid/SQLA datasource model, but if we remove the Druid connector for 2.0, then this will be much easier implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org