You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/08 06:54:53 UTC

[GitHub] [flink] paul8263 opened a new pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

paul8263 opened a new pull request #16419:
URL: https://github.com/apache/flink/pull/16419


   …s in the past
   
   ## What is the purpose of the change
   
   Fixed flame graphs says it is 18800 days in the past when Flink returns an empty flame graph.
   
   ## Brief change log
   
   - flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] paul8263 commented on a change in pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

paul8263 commented on a change in pull request #16419:
URL: https://github.com/apache/flink/pull/16419#discussion_r668474753



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html
##########
@@ -41,6 +41,6 @@
   <nz-spin *ngIf="isLoading"></nz-spin>
 </div>
 
-
-
-
+<ng-template #notAvailable>
+  <span>Flame graph is currently unavailable</span>

Review comment:
       Pls consider my solution in FLINK-23102. Pls comment below if there is anything else for me to do.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-876190677


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "06028ccdfb991eb4e82525e0f23520add2b722be",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20146",
       "triggerID" : "06028ccdfb991eb4e82525e0f23520add2b722be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06028ccdfb991eb4e82525e0f23520add2b722be Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20146) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] NicoK commented on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

NicoK commented on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-891617120


   Fixed via #16352.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-876183073

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 06028ccdfb991eb4e82525e0f23520add2b722be (Sat Aug 28 13:07:24 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] paul8263 commented on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

paul8263 commented on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-881097245


   Pls consider my solution in FLINK-23102. If there is anything else for me to do, please comment below. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] NicoK commented on a change in pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

NicoK commented on a change in pull request #16419:
URL: https://github.com/apache/flink/pull/16419#discussion_r665956438



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html
##########
@@ -41,6 +41,6 @@
   <nz-spin *ngIf="isLoading"></nz-spin>
 </div>
 
-
-
-
+<ng-template #notAvailable>
+  <span>Flame graph is currently unavailable</span>

Review comment:
       I'm thinking of your comment about https://issues.apache.org/jira/browse/FLINK-22527 - should this be solved here instead of inside https://github.com/apache/flink/pull/16352?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-876190677


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "06028ccdfb991eb4e82525e0f23520add2b722be",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20146",
       "triggerID" : "06028ccdfb991eb4e82525e0f23520add2b722be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06028ccdfb991eb4e82525e0f23520add2b722be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20146) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-876190677


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "06028ccdfb991eb4e82525e0f23520add2b722be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "06028ccdfb991eb4e82525e0f23520add2b722be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06028ccdfb991eb4e82525e0f23520add2b722be UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #16419:
URL: https://github.com/apache/flink/pull/16419#issuecomment-876183073

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 06028ccdfb991eb4e82525e0f23520add2b722be (Thu Jul 08 06:58:20 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] NicoK commented on a change in pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

NicoK commented on a change in pull request #16419:
URL: https://github.com/apache/flink/pull/16419#discussion_r665960650



##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html
##########
@@ -41,6 +41,6 @@
   <nz-spin *ngIf="isLoading"></nz-spin>
 </div>
 
-
-
-
+<ng-template #notAvailable>
+  <span>Flame graph is currently unavailable</span>

Review comment:
       In that case, since (afaik) we can't distinguish between the Flamegraphs being disabled vs. us just waiting for the first results to appear, we'd have to provide a generic text like
   > Flame graph currently unavailable
   > We are either waiting for the first samples to create a flame graph or this feature is currently disabled (enable it by setting [`rest.flamegraph.enabled: true`](https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/deployment/config/#rest-flamegraph-enabled))
   
   If we can actually distinguish the two, then splitting these scenarios up into two different messages would be even better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] NicoK closed pull request #16419: [FLINK-23101][runtime] Flame Graphs initial view says it is 18800 day…

Posted by GitBox <gi...@apache.org>.

NicoK closed pull request #16419:
URL: https://github.com/apache/flink/pull/16419


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org