You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/17 01:45:47 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission

ruanwenjun commented on code in PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#discussion_r1024673806


##########
dolphinscheduler-worker/src/main/bin/start.sh:
##########
@@ -21,7 +21,6 @@ DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/..; pwd)}
 
 source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"
 
-chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf

Review Comment:
   Remove `chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf` is ok for me.
   
   If fact, `${DOLPHINSCHEDULER_HOME}/conf/dolphinscheduler_env.sh` is the default env faile will be sourced by task, we can change this in common.properties `dolphinscheduler.env.path`.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org