[Impala-ASF-CR] IMPALA-10888: sort partitions by name before comparing in test

["Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>]

Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17812 )

Change subject: IMPALA-10888: sort partitions by name before comparing in test
......................................................................

IMPALA-10888: sort partitions by name before comparing in test

CatalogHmsFileMetadataTest and EnableCatalogdHmsCacheFlagTest
compare the partition filemetada which is returned over by
get_partitions_by_names HMS API. However, the catalogd's
implementation of API does not return the partitions in a
deterministic order. Hence the tests can fail intermittently.

The patch sorts the returned partitions by names before
making any comparisons to avoid the flakiness of the test.

Testing:
1. Modified existing test to do the sorting before
asserting the filemetadata comparison.

Change-Id: I75aa9d714e888ec7f7efd62e475ba1d3a3342256
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/test/java/org/apache/impala/catalog/metastore/AbstractCatalogMetastoreTest.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java
M fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java
4 files changed, 42 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/17812/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75aa9d714e888ec7f7efd62e475ba1d3a3342256
Gerrit-Change-Number: 17812
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>