You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Dave Fisher <wa...@comcast.net> on 2023/05/26 02:54:37 UTC

Re: [pulsar-site] branch main updated: fix revert to use the latest stable version by default

Hi -

I like this change!

Thanks,
Dave

Sent from my iPhone

> On May 25, 2023, at 7:36 PM, tison@apache.org wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> tison pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
> 
> 
> The following commit(s) were added to refs/heads/main by this push:
>     new b30efcce68c fix revert to use the latest stable version by default
> b30efcce68c is described below
> 
> commit b30efcce68ceeda50f960cec2a22fe0f1194d233
> Author: tison <wa...@gmail.com>
> AuthorDate: Fri May 26 10:36:33 2023 +0800
> 
>    fix revert to use the latest stable version by default
> 
>    Signed-off-by: tison <wa...@gmail.com>
> ---
> docusaurus.config.js | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/docusaurus.config.js b/docusaurus.config.js
> index d6484c7c78a..9eba10a8727 100644
> --- a/docusaurus.config.js
> +++ b/docusaurus.config.js
> @@ -173,13 +173,13 @@ module.exports = {
>           position: "left",
>           items: [
>             {
> -              to: "/docs/next/concepts-overview/",
> -              activeBaseRegex: "docs/next/concepts-overview/$",
> +              type: 'doc',
> +              docId: 'concepts-overview',
>               label: "Concepts",
>             },
>             {
> -              to: "/docs/next/",
> -              activeBaseRegex: "docs/next/$",
> +              type: 'doc',
> +              docId: 'about',
>               label: "Quickstart",
>             },
>             {
> 


Re: [pulsar-site] branch main updated: fix revert to use the latest stable version by default

Posted by Kiryl Valkovich <ki...@teal.tools>.
I submitted a PR that fixes both:
- link to the latest version
- two highlighted menu items at the same time, that was the original reason for the changes in docusaurus.config.json

https://github.com/apache/pulsar-site/pull/587


Best,
Kiryl


From: tison <wa...@gmail.com>
Date: Friday, May 26, 2023 at 5:02 AM
To: dev@pulsar.apache.org <de...@pulsar.apache.org>
Subject: Re: [pulsar-site] branch main updated: fix revert to use the latest stable version by default
This is actually the manner before we merge the redesign PR - I miss this
part when reviewing the redesign PR >_<

Best,
tison.


Dave Fisher <wa...@comcast.net> 于2023年5月26日周五 10:54写道:

> Hi -
>
> I like this change!
>
> Thanks,
> Dave
>
> Sent from my iPhone
>
> > On May 25, 2023, at 7:36 PM, tison@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > tison pushed a commit to branch main
> > in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
> >
> >
> > The following commit(s) were added to refs/heads/main by this push:
> >     new b30efcce68c fix revert to use the latest stable version by
> default
> > b30efcce68c is described below
> >
> > commit b30efcce68ceeda50f960cec2a22fe0f1194d233
> > Author: tison <wa...@gmail.com>
> > AuthorDate: Fri May 26 10:36:33 2023 +0800
> >
> >    fix revert to use the latest stable version by default
> >
> >    Signed-off-by: tison <wa...@gmail.com>
> > ---
> > docusaurus.config.js | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/docusaurus.config.js b/docusaurus.config.js
> > index d6484c7c78a..9eba10a8727 100644
> > --- a/docusaurus.config.js
> > +++ b/docusaurus.config.js
> > @@ -173,13 +173,13 @@ module.exports = {
> >           position: "left",
> >           items: [
> >             {
> > -              to: "/docs/next/concepts-overview/",
> > -              activeBaseRegex: "docs/next/concepts-overview/$",
> > +              type: 'doc',
> > +              docId: 'concepts-overview',
> >               label: "Concepts",
> >             },
> >             {
> > -              to: "/docs/next/",
> > -              activeBaseRegex: "docs/next/$",
> > +              type: 'doc',
> > +              docId: 'about',
> >               label: "Quickstart",
> >             },
> >             {
> >
>
>

Re: [pulsar-site] branch main updated: fix revert to use the latest stable version by default

Posted by tison <wa...@gmail.com>.
This is actually the manner before we merge the redesign PR - I miss this
part when reviewing the redesign PR >_<

Best,
tison.


Dave Fisher <wa...@comcast.net> 于2023年5月26日周五 10:54写道:

> Hi -
>
> I like this change!
>
> Thanks,
> Dave
>
> Sent from my iPhone
>
> > On May 25, 2023, at 7:36 PM, tison@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > tison pushed a commit to branch main
> > in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
> >
> >
> > The following commit(s) were added to refs/heads/main by this push:
> >     new b30efcce68c fix revert to use the latest stable version by
> default
> > b30efcce68c is described below
> >
> > commit b30efcce68ceeda50f960cec2a22fe0f1194d233
> > Author: tison <wa...@gmail.com>
> > AuthorDate: Fri May 26 10:36:33 2023 +0800
> >
> >    fix revert to use the latest stable version by default
> >
> >    Signed-off-by: tison <wa...@gmail.com>
> > ---
> > docusaurus.config.js | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/docusaurus.config.js b/docusaurus.config.js
> > index d6484c7c78a..9eba10a8727 100644
> > --- a/docusaurus.config.js
> > +++ b/docusaurus.config.js
> > @@ -173,13 +173,13 @@ module.exports = {
> >           position: "left",
> >           items: [
> >             {
> > -              to: "/docs/next/concepts-overview/",
> > -              activeBaseRegex: "docs/next/concepts-overview/$",
> > +              type: 'doc',
> > +              docId: 'concepts-overview',
> >               label: "Concepts",
> >             },
> >             {
> > -              to: "/docs/next/",
> > -              activeBaseRegex: "docs/next/$",
> > +              type: 'doc',
> > +              docId: 'about',
> >               label: "Quickstart",
> >             },
> >             {
> >
>
>