You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2015/05/27 16:20:58 UTC
Re: qpid-proton git commit: PROTON-885: add pthreads option to swig
command
You're adding the word "thread" to the python codebase? Won't something
explode?
On Tue, 2015-05-26 at 21:32 +0000, kgiusti@apache.org wrote:
> Repository: qpid-proton
> Updated Branches:
> refs/heads/master a3fc3ffa2 -> 0b7718c74
>
>
> PROTON-885: add pthreads option to swig command
>
>
> Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
> Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/0b7718c7
> Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/0b7718c7
> Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/0b7718c7
>
> Branch: refs/heads/master
> Commit: 0b7718c74a8fc905cc209b4859408feae5805029
> Parents: a3fc3ff
> Author: Ken Giusti <kg...@apache.org>
> Authored: Tue May 26 16:58:13 2015 -0400
> Committer: Ken Giusti <kg...@apache.org>
> Committed: Tue May 26 17:17:00 2015 -0400
>
> ----------------------------------------------------------------------
> proton-c/bindings/python/setuputils/misc.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/0b7718c7/proton-c/bindings/python/setuputils/misc.py
> ----------------------------------------------------------------------
> diff --git a/proton-c/bindings/python/setuputils/misc.py b/proton-c/bindings/python/setuputils/misc.py
> index 3ebb160..8978371 100644
> --- a/proton-c/bindings/python/setuputils/misc.py
> +++ b/proton-c/bindings/python/setuputils/misc.py
> @@ -30,7 +30,7 @@ def settings_from_prefix(prefix=None):
> settings['libraries'] = []
> settings['include_dirs'] = []
> settings['library_dirs'] = []
> - settings['swig_opts'] = []
> + settings['swig_opts'] = ['-threads']
> settings['runtime_library_dirs'] = []
> settings['extra_link_args'] = []
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> For additional commands, e-mail: commits-help@qpid.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: qpid-proton git commit: PROTON-885: add pthreads option to swig
command
Posted by Ken Giusti <kg...@redhat.com>.
Yes: my head.
Swig needs to know if the generated code needs to be 'thread safe'. From what I can tell, without that flag programs that use Threading will break (and do, in my testing).
----- Original Message -----
> From: "Alan Conway" <ac...@redhat.com>
> To: dev@qpid.apache.org
> Sent: Wednesday, May 27, 2015 10:20:58 AM
> Subject: Re: qpid-proton git commit: PROTON-885: add pthreads option to swig command
>
> You're adding the word "thread" to the python codebase? Won't something
> explode?
>
>
> On Tue, 2015-05-26 at 21:32 +0000, kgiusti@apache.org wrote:
> > Repository: qpid-proton
> > Updated Branches:
> > refs/heads/master a3fc3ffa2 -> 0b7718c74
> >
> >
> > PROTON-885: add pthreads option to swig command
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/0b7718c7
> > Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/0b7718c7
> > Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/0b7718c7
> >
> > Branch: refs/heads/master
> > Commit: 0b7718c74a8fc905cc209b4859408feae5805029
> > Parents: a3fc3ff
> > Author: Ken Giusti <kg...@apache.org>
> > Authored: Tue May 26 16:58:13 2015 -0400
> > Committer: Ken Giusti <kg...@apache.org>
> > Committed: Tue May 26 17:17:00 2015 -0400
> >
> > ----------------------------------------------------------------------
> > proton-c/bindings/python/setuputils/misc.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/0b7718c7/proton-c/bindings/python/setuputils/misc.py
> > ----------------------------------------------------------------------
> > diff --git a/proton-c/bindings/python/setuputils/misc.py
> > b/proton-c/bindings/python/setuputils/misc.py
> > index 3ebb160..8978371 100644
> > --- a/proton-c/bindings/python/setuputils/misc.py
> > +++ b/proton-c/bindings/python/setuputils/misc.py
> > @@ -30,7 +30,7 @@ def settings_from_prefix(prefix=None):
> > settings['libraries'] = []
> > settings['include_dirs'] = []
> > settings['library_dirs'] = []
> > - settings['swig_opts'] = []
> > + settings['swig_opts'] = ['-threads']
> > settings['runtime_library_dirs'] = []
> > settings['extra_link_args'] = []
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: commits-help@qpid.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>
--
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org