You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2020/10/22 19:00:05 UTC

[GitHub] [jclouds] ahgittin commented on pull request #78: Replace embedded and repackaged GSON library

ahgittin commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714696642


   Seems to me like this PR is introducing two significant changes:
   
   * use `bnd` instead of `jclouds.osgi.{im,ex}port` maven properties
   * change how `gson` is imported/exported
   
   If it's possible to have a PR for the first of these to be discussed, and then a second for gson, that will make it much easier to consider.
   
   The former (`bnd`) seems like a reasonable idea to me.  It's messy either way but slightly less messy.
   
   The latter (`gson` change) is still confusing to me and as per the mailing list my gut says we're better of not touching it unless we are fixing it properly such as by moving to Jackson.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org