[GitHub] [maven] michael-o commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #1098:
URL: https://github.com/apache/maven/pull/1098#discussion_r1185835588


##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -364,6 +369,38 @@ public void testVersionStringWithoutAnsi() throws Exception {
         assertEquals(MessageUtils.stripAnsiCodes(versionOut), versionOut);
     }
 
+    @Test
+    public void testPropertiesInterpolation() throws Exception {
+        // Arrange
+        CliRequest request = new CliRequest(
+                new String[] {
+                    "-Dfoo=bar",
+                    "-DvalFound=s${foo}i",
+                    "-DvalNotFound=s${foz}i",
+                    "-DvalRootDirectory=${session.rootDirectory}/.mvn/foo",
+                    "-DvalTopDirectory=${session.topDirectory}/pom.xml",

Review Comment:
   I have a problem with these two expressions: They haven't been back ported to 3.9.x, no? So they are fake here and not work throughout the entire build?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org