[jira] [Commented] (GEODE-8909) Support Redis HDEL command

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278128#comment-17278128 ] 

ASF GitHub Bot commented on GEODE-8909:
---------------------------------------

sabbey37 commented on a change in pull request #5993:
URL: https://github.com/apache/geode/pull/5993#discussion_r569551084



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHashesIntegrationTest.java
##########
@@ -363,12 +384,6 @@ public void testHExists() {
     jedis.hset(key, field, value);
 
     assertThat(jedis.hexists(key, field)).isTrue();
-
-    jedis.hdel(key, field);
-
-    assertThat(jedis.hget(key, field)).isNull();
-    assertThat(jedis.hexists(key, field)).isFalse();
-

Review comment:
       Since this test is specifically testing `HEXISTS`, wouldn't it be good to keep this basic case of deleting a field then making sure `HEXISTS` returns false for that field?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support Redis HDEL command
> --------------------------
>
>                 Key: GEODE-8909
>                 URL: https://issues.apache.org/jira/browse/GEODE-8909
>             Project: Geode
>          Issue Type: Test
>          Components: redis
>            Reporter: Jens Deppe
>            Priority: Major
>
> Check test coverage
> Move command to SUPPORTED



--
This message was sent by Atlassian Jira
(v8.3.4#803005)