[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

["Nicolas Malin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903150#comment-16903150 ] 

Nicolas Malin edited comment on OFBIZ-10145 at 8/8/19 5:10 PM:
---------------------------------------------------------------

I tried to load new gradle wrapper version in current bintray repository without success [1] so I continued with open I new account and load needed version.
This work fine [2] but is under my name (during my test :) )

Now if no opposition,  I can open a real account for Apache OFBiz (managed by PMC) and terminate this task adter loading all wrapper used \o/

[1] https://bintray.com/bintray/jcenter/org.gradle:gradle-wrapper
[2] https://bintray.com/nicolasmalin/GradleWrapper/org.gradle.gradle-wrapper

----
With this test, I use these variables on script

{code:sh}
GRADLE_WRAPPER_URI="https://github.com/gradle/gradle/raw/v$RELEASE/gradle/wrapper/"
GRADLE_WRAPPER_URI_BACKUP="https://bintray.com/api/ui/download/nicolasmalin/GradleWrapper/v$RELEASE/"
{code}



was (Author: soledad):
I tried to load new gradle wrapper version in current bintray repository without success [1] so I continued with open I new account and load needed version.
This work fine [2] but is under my name (during my test :) )

Now if no opposition,  I can open a real account for Apache OFBiz (managed by PMC) and terminate this task adter loading all wrapper used \o/

[1] https://bintray.com/bintray/jcenter/org.gradle:gradle-wrapper
[2] https://bintray.com/nicolasmalin/GradleWrapper/org.gradle.gradle-wrapper

> Remove the Gradle wrapper from our release packages and add a step to our build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Nicolas Malin
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, init-gradlew-readme.patch, release-16.11-without-gradlew.patch, release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, considering LEGAL-288 and based on a lazy consensus on dev ML, we want to remove the gradle-wrapper.jar file from the next packaged releases and  use [~jacopoc]'s related proposition to document how to have Gradle working in the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the gradle-wrapper.jar. This might change in the future (versions, etc.), so indeed maybe simply asking to download is enough, cf  https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)