You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/01 15:51:15 UTC
[jira] Created: (CASSANDRA-34) Hinted handoff rows never get
deleted
Hinted handoff rows never get deleted
-------------------------------------
Key: CASSANDRA-34
URL: https://issues.apache.org/jira/browse/CASSANDRA-34
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
Prashant verified that this is a bug that can't be fixed until deletes are fully working.
Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706068#action_12706068 ]
Jonathan Ellis commented on CASSANDRA-34:
-----------------------------------------
(incorporated changes for comments (1) and (2) into my patchset, not bothering resubmitting those unless you really want 'em)
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, 0003-tombstones-take-priority-over-non-tombstones-w-the.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705420#action_12705420 ]
Jonathan Ellis commented on CASSANDRA-34:
-----------------------------------------
created CASSANDRA-128 for improvments beyond the scope of 0.3
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705319#action_12705319 ]
Jonathan Ellis commented on CASSANDRA-34:
-----------------------------------------
any idea what the purpose of this code in runHints is? why flush if nothing changed?
if(hintedColumnFamily == null)
{
columnFamilyStore_.forceFlush();
return;
}
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705379#action_12705379 ]
Jonathan Ellis commented on CASSANDRA-34:
-----------------------------------------
committed the sendMessage fix. I've reworked the rest substantially in two parts.
01 is just refactoring / cleanup.
02 includes your fix to deleteKey, and also:
A make hint generation include a real timestamp so we can do meaningful deletes
B call removeDeleted on the data we read locally to purge tombstones
C because of (B) any supercolumn w/o subcolumns simply won't exist so we know we can skip re-deleting the endpoint data. so deleteKey becomes deleteHintedData.
D because deleted data is not immediately purged, increased the scheduled interval fro 20min to 60 to reduce the load of scanning the hint CF.
(for another ticket: since all this is purely local data and not subject to read repair we should find a way to GC it immediately post-delete.)
how does this look to you?
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706089#action_12706089 ]
Jun Rao commented on CASSANDRA-34:
----------------------------------
Comments for the new patch.
1. In CFStore.removeDeleted(), we should add comments to explain how we resolve the conflicts among CF, SC, and C when the timestamps are the same. As time goes, we are likely to forget those decisions that we have made.
Other than that, the patch looks fine to me.
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, 0003-tombstones-take-priority-over-non-tombstones-w-the.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-34:
------------------------------------
Attachment: 0002-fix-HHM.patch
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705835#action_12705835 ]
Jun Rao commented on CASSANDRA-34:
----------------------------------
4. It's probably worthwhile to make intervalInMins_ in HHM configurable.
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-34:
---------------------------------------
Assignee: (was: Jonathan Ellis)
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-34:
------------------------------------
Attachment: 0001-cleanup.patch
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-34:
------------------------------------
Fix Version/s: 0.3
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706897#action_12706897 ]
Hudson commented on CASSANDRA-34:
---------------------------------
Integrated in Cassandra #63 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/63/])
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jun Rao
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, 0003-tombstones-take-priority-over-non-tombstones-w-the.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-34:
------------------------------------
Attachment: 0003-tombstones-take-priority-over-non-tombstones-w-the.patch
patch to make tombstones have higher precedence than non- for same timestamp in Column (and SuperColumn, to be consistent w/ C and CF)
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, 0003-tombstones-take-priority-over-non-tombstones-w-the.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated CASSANDRA-34:
-----------------------------
Attachment: issue34.patch_v2
Patch v2. Added some description on hinted data gets delivered.
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-34:
---------------------------------------
Assignee: Jun Rao (was: Jonathan Ellis)
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jun Rao
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, 0003-tombstones-take-priority-over-non-tombstones-w-the.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706071#action_12706071 ]
Jonathan Ellis commented on CASSANDRA-34:
-----------------------------------------
noted comment (4) on CASSANDRA-128
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, 0003-tombstones-take-priority-over-non-tombstones-w-the.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705415#action_12705415 ]
Hudson commented on CASSANDRA-34:
---------------------------------
Integrated in Cassandra #57 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/57/])
make sendMessage only return true after ack by recipient.
patch by Jun Rao; reviewed by jbellis for
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705833#action_12705833 ]
Jun Rao commented on CASSANDRA-34:
----------------------------------
Looked at the new patch. Here are some comments.
1. Move the comments above sendMessage to the beginning of class.
2. There is compilation error in MinorCompactionManager because of the removed HintedHandOff class.
3. Your new code deletes a column using the same timestamp as the column to be deleted. This is a more fundamental question. If a column has a non-delete entry and a deleted entry with the same timestamp, which one wins? I don't think that we can rely on the ordering of the insertion/deletion. This is because the insertion and the deletion can end up in different SSTables. During compaction, FileStruct is sorted only by keys. Therefore, columns from different SSTables with the same key can come in arbitrary order. One solution is to modify CF.addColumn such that a deletion always wins when the column timestamp is the same. Not sure if there is any other implications, though.
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-cleanup.patch, 0002-fix-HHM.patch, issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated CASSANDRA-34:
-----------------------------
Attachment: issue34.patch_v1
Attach a fix. About the patch.
1. Make sendMessage blocking.
2. Delete the rows in application CF after hinted data is sent. To do that, we need to collect the largest timestamp among columns in a CF and then delete the CF with the largest timestamp.
3. When a column is in a deleted CF and their timestamps are the same, the rule is that the deleted CF wins. This rule is needed for step 2 above. Change CFStore.removeDeleted according to this rule.
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: issue34.patch_v1
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-34) Hinted handoff rows never get
deleted
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705321#action_12705321 ]
Jonathan Ellis commented on CASSANDRA-34:
-----------------------------------------
also, now that we have range queries, it seems that a normal CF would be a better fit for this than a single super CF with keys as supercolumns. i guess that is a separate issue.
> Hinted handoff rows never get deleted
> -------------------------------------
>
> Key: CASSANDRA-34
> URL: https://issues.apache.org/jira/browse/CASSANDRA-34
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: issue34.patch_v1, issue34.patch_v2
>
>
> from the list: "after the hints are delivered, the hinted keys are deleted from the hinted CF only, but not from the application CF."
> Prashant verified that this is a bug that can't be fixed until deletes are fully working.
> Note: when we fix this, see if we can do so w/o compromising the immediate-GC of the hinted CF keys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.