You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/05/16 12:04:35 UTC

Review Request 59308: Add docker support for infra manager

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59308/
-----------------------------------------------------------

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-21031
    https://issues.apache.org/jira/browse/AMBARI-21031


Repository: ambari


Description
-------

add docker support & update readme.md

run infra-manager-docker.sh in docker folder if docker is installed

small addition: added infra-manager-env.sh file as well to the rpm


Diffs
-----

  ambari-infra/ambari-infra-assembly/pom.xml 550d97c 
  ambari-infra/ambari-infra-manager/README.md 033bbb2 
  ambari-infra/ambari-infra-manager/build.xml c7954d9 
  ambari-infra/ambari-infra-manager/docker/Dockerfile PRE-CREATION 
  ambari-infra/ambari-infra-manager/docker/bin/start.sh PRE-CREATION 
  ambari-infra/ambari-infra-manager/docker/infra-manager-docker.sh PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/resources/infra-manager-env.sh PRE-CREATION 
  ambari-infra/ambari-infra-manager/src/main/resources/infraManager.sh 9f40d5c 


Diff: https://reviews.apache.org/r/59308/diff/1/


Testing
-------

done.


Thanks,

Oliver Szabo

Re: Review Request 59308: Add docker support for infra manager

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59308/#review175267
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On May 16, 2017, 12:04 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59308/
> -----------------------------------------------------------
> 
> (Updated May 16, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21031
>     https://issues.apache.org/jira/browse/AMBARI-21031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add docker support & update readme.md
> 
> run infra-manager-docker.sh in docker folder if docker is installed
> 
> small addition: added infra-manager-env.sh file as well to the rpm
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-assembly/pom.xml 550d97c 
>   ambari-infra/ambari-infra-manager/README.md 033bbb2 
>   ambari-infra/ambari-infra-manager/build.xml c7954d9 
>   ambari-infra/ambari-infra-manager/docker/Dockerfile PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/bin/start.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/infra-manager-docker.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infra-manager-env.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infraManager.sh 9f40d5c 
> 
> 
> Diff: https://reviews.apache.org/r/59308/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59308: Add docker support for infra manager

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59308/#review175241
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On May 16, 2017, 12:04 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59308/
> -----------------------------------------------------------
> 
> (Updated May 16, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21031
>     https://issues.apache.org/jira/browse/AMBARI-21031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add docker support & update readme.md
> 
> run infra-manager-docker.sh in docker folder if docker is installed
> 
> small addition: added infra-manager-env.sh file as well to the rpm
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-assembly/pom.xml 550d97c 
>   ambari-infra/ambari-infra-manager/README.md 033bbb2 
>   ambari-infra/ambari-infra-manager/build.xml c7954d9 
>   ambari-infra/ambari-infra-manager/docker/Dockerfile PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/bin/start.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/infra-manager-docker.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infra-manager-env.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infraManager.sh 9f40d5c 
> 
> 
> Diff: https://reviews.apache.org/r/59308/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>