[GitHub] [beam] kamilwu commented on a change in pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

[GitBox <gi...@apache.org>]

kamilwu commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r431052998



##########
File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json
##########
@@ -0,0 +1,297 @@
+{

Review comment:
       @tvalentyn 
   
   > Is there a way to visualize the dashboard on an in-progress PR?
   
   Currently, the best way is to: pull branch, deploy metrics stack locally (`docker-compose build`; `docker-compose up`), open web browser and go to localhost:3000.
   
   > Is it possible to reduce duplication in the configs?
   
   There's a concept called [Scripted Dashboards](https://grafana.com/docs/grafana/latest/reference/scripting/), but we didn't implement it. So, if we want to create two dashboards next to each other, we have to provide two configs for them (even if they are very similar). 
   
   Apart from that, we can also consider another question: is having those .json files version-controlled profitable? Diffs are often very large, so the standard review process does not apply here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org