You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/31 05:13:28 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35369: [SPARK-38076][CORE] Remove redundant null-check is covered by further condition
LuciferYang opened a new pull request #35369:
URL: https://github.com/apache/spark/pull/35369
### What changes were proposed in this pull request?
There are many code pattern as follows:
```java
obj != null && obj instanceof SomeClass
```
the null-check is redundant as `instanceof` operator implies non-nullity, so this pr remove the redundant `null-check`.
### Why are the changes needed?
Code simplification
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35369: [SPARK-38076][CORE] Remove redundant null-check is covered by further condition
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35369:
URL: https://github.com/apache/spark/pull/35369#issuecomment-1027669636
thanks @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35369: [SPARK-38076][CORE] Remove redundant null-check is covered by further condition
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35369:
URL: https://github.com/apache/spark/pull/35369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35369: [SPARK-38076][CORE] Remove redundant null-check is covered by further condition
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35369:
URL: https://github.com/apache/spark/pull/35369#issuecomment-1025388786
This is all in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #35369: [SPARK-38076][CORE] Remove redundant null-check is covered by further condition
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #35369:
URL: https://github.com/apache/spark/pull/35369#issuecomment-1025388786
This is all in Spark Java code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org