You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/10/14 10:11:14 UTC

[Bug 8062] New: no URL makes uridnsbl rules "unrun"

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

            Bug ID: 8062
           Summary: no URL makes uridnsbl rules "unrun"
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P2
         Component: Plugins
          Assignee: dev@spamassassin.apache.org
          Reporter: apache@hege.li
  Target Milestone: Undefined

On sa-users list from Wolfgang Breyha:


If a scanned E-Mail does not contain any URL (URIHOSTS and URIDOMAINS empty)
SA4(rc3) does not mark rules using check_uridnsbl as "run" IMO.

This makes meta rules depending on them "unrunable" as well.

Dbg Output from an example:
> Oct 14 11:51:01.140 [3032346] dbg: check: tagrun - tag URIHOSTS is now ready, value: ARY:[]
> Oct 14 11:51:01.140 [3032346] dbg: check: tagrun - tag URIDOMAINS is now ready, value: ARY:[]
...
> Oct 14 11:51:01.215 [3032346] dbg: rules-all: running eval rule URIBL_BLACK (check_uridnsbl)
...
> Oct 14 11:51:47.392 [3032346] dbg: rules-all: unrun dependencies prevented meta SPF_PASS_SPAM from running: URIBL_BLACK

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5846|0                           |1
        is obsolete|                            |

--- Comment #2 from Henrik Krohns <ap...@hege.li> ---
Created attachment 5847
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5847&action=edit
Fix unused rules

Here's my patch so no to need hassle with ICLA.. reuses the previously unused
uridnsbl_activerules variable and checks that bgsend succeeded. Vote to commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Wolfgang Breyha <wb...@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wbreyha@gmx.net

--- Comment #1 from Wolfgang Breyha <wb...@gmx.net> ---
Created attachment 5846
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5846&action=edit
possible fix

I'm currently trying attached patch. At least with my testcases it looks
promising.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Giovanni Bechis <gi...@paclan.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovanni@paclan.it

--- Comment #5 from Giovanni Bechis <gi...@paclan.it> ---
+1 to commit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062
Bug 8062 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |billcole@apache.org

--- Comment #3 from Bill Cole <bi...@apache.org> ---
+1 TO COMMIT

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062
Bug 8062 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062
Bug 8062 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apache@hege.li
   Target Milestone|Undefined                   |4.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Matija Nalis <mn...@voyager.hr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnalis-sabug@voyager.hr

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062
Bug 8062 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|no URL makes uridnsbl rules |[review] no URL makes
                   |"unrun"                     |uridnsbl rules "unrun"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062
Bug 8062 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@apache.org

--- Comment #4 from Kevin A. McGrail <km...@apache.org> ---
+1 from me as well, ty  this should close 7736 as well, I believe.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7735


Referenced Bugs:

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735
[Bug 7735] Meta rules need to handle missing/unrun dependencies
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Henrik Krohns <ap...@hege.li> ---
Sending        trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Transmitting file data .done
Committing transaction...
Committed revision 1904811.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8062] [review] no URL makes uridnsbl rules "unrun"

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062
Bug 8062 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are the assignee for the bug.