[GitHub] jjrodrig opened a new pull request #1139: Fix for issue #1136 - Error 500 deleting DB without quorum

[GitBox <gi...@apache.org>]

jjrodrig opened a new pull request #1139: Fix for issue #1136 - Error 500 deleting DB without quorum
URL: https://github.com/apache/couchdb/pull/1139
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   The current behaviour for database deletion in a cluster is:
   - Database deletion returns 404 - Not found if all nodes respond not found 
   - Database deletion returns 200 - OK if all nodes respond and at least one is ok
   - Database deletion returns 202 - Accepted if the number of responses met quorum and at least one is ok
   - Database deletion returns 500 - Error if the responses are bellow quorum
   
   After this PR the behaviour for database deletetion will be:
   - Database deletion returns 404 - Not found if all nodes respond not found 
   - Database deletion returns 200 - OK if the quorum is met and at least one is ok
   - Database deletion returns 202 - Accepted if the number of responses are bellow quorum and at least one is ok
   - Database deletion returns 500 - Error in other cases
   
   
   ## Testing recommendations
   
   This PR can be tested in this way
   ```
    make test-cluster-with-quorum
    make test-cluster-without-quorum
   ```
   New test for db deletion is included
   
   Side change in **test/javascript/run** 
   I've included a change in test/javascript/run. Now the script does not exit with error if the parameter suites or ignore_js_suites is provided with a value that is not matched with an existing test.
   
   After this PR, it is possible to run `make check ignore_js_suites=reduce_builtin` or  `make check suites=all_docs` without getting an error in the new cluster testing targets.
   
   ## Related Issues or Pull Requests
   Fixes #1136 
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services