You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/17 19:29:06 UTC

[GitHub] [beam] TheNeuralBit commented on pull request #13457: [BEAM-12530] Make FakePandasObject handle inline pandas objects

TheNeuralBit commented on pull request #13457:
URL: https://github.com/apache/beam/pull/13457#issuecomment-922030920


   I'm going to revert this, as it's really only beneficial for `pandas_docs_test`, which we don't run continuously (instead relying on `frames_test` and `pandas_doctests_test` for compatibility checks.
   
   Also I don't think this change is actually capturing the `pd.DataFrame({'col': pd.Series(..)})` case I mentioned. For that I think we'd need to modify the `_monkey_patch_type` method, rather than `FakePandasObject`, which is capturing top level functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org