You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/26 23:12:16 UTC

[kudu-CR] [java] KUDU-2671 fix bug in PartitionSchema::getHashSchemaForRange()

Hello Mahesh Reddy, Attila Bukor, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18782

to look at the new patch set (#3).

Change subject: [java] KUDU-2671 fix bug in PartitionSchema::getHashSchemaForRange()
......................................................................

[java] KUDU-2671 fix bug in PartitionSchema::getHashSchemaForRange()

This patch fixes a bug in PartitionSchema::getHashSchemaForRange()
that manifested itself when a right-side unbounded range with custom
hash schema was present in a table.

The patch also contains test scenarios that allowed to see the
manifestation of the bug before the fix; from now they allow to spot
regressions in the corresponding code, if any.  These scenarios cover
both {Create,Alter}Table code paths when adding right-side unbounded
ranges with custom hash schemas.

Change-Id: Ib0ef5bbe4528ce5c1d4c9591a8152cf7ec4af0bb
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
3 files changed, 206 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/18782/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0ef5bbe4528ce5c1d4c9591a8152cf7ec4af0bb
Gerrit-Change-Number: 18782
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>