You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/28 15:39:47 UTC

[GitHub] [airflow] mjpieters opened a new pull request #10633: Ensure all statsd timers use millisecond values.

mjpieters opened a new pull request #10633:
URL: https://github.com/apache/airflow/pull/10633


   This is my fix for the statsd timers reporting values as milliseconds. This pull request is essentially a backport of two pull request:
   
   - #6682 (already merged)
   - #10632 (my pull request for this issue for the master branch)
   
   The updated code passes `timedelta()` objects to `StatsClient.timing()`, and leaves worrying about the right unit of time to the client library.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #10633: Ensure all statsd timers use millisecond values.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10633:
URL: https://github.com/apache/airflow/pull/10633#issuecomment-717542965


   [The Workflow run](https://github.com/apache/airflow/actions/runs/332226862) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #10633: Ensure all statsd timers use millisecond values.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10633:
URL: https://github.com/apache/airflow/pull/10633#issuecomment-726715595


   [The Workflow run](https://github.com/apache/airflow/actions/runs/361372762) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #10633: Ensure all statsd timers use millisecond values.

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10633:
URL: https://github.com/apache/airflow/pull/10633


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw commented on pull request #10633: Ensure all statsd timers use millisecond values.

Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #10633:
URL: https://github.com/apache/airflow/pull/10633#issuecomment-683837496


   @schnie can you review to determine if this would have any impact on our statsd implementation?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mjpieters commented on pull request #10633: Ensure all statsd timers use millisecond values.

Posted by GitBox <gi...@apache.org>.
mjpieters commented on pull request #10633:
URL: https://github.com/apache/airflow/pull/10633#issuecomment-726719945


   Another rebase, another unrelated CI failure :-/. Same remarks as [on my other 1-10 pending PR](https://github.com/apache/airflow/pull/10885#issuecomment-726718756).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org