[jira] [Created] (RYA-135) Confusing configuration: CONF_TBL_PREFIX versus MONGO_COLLECTION_PREFIX versus RyaInstance

["David W. Lotts (JIRA)" <ji...@apache.org>]

David W. Lotts created RYA-135:
----------------------------------

             Summary: Confusing configuration: CONF_TBL_PREFIX versus  MONGO_COLLECTION_PREFIX versus RyaInstance
                 Key: RYA-135
                 URL: https://issues.apache.org/jira/browse/RYA-135
             Project: Rya
          Issue Type: Improvement
          Components: sail
         Environment: 
Around line 73,  "" 
        conf.set(MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX, "rya_");
        conf.set(RdfCloudTripleStoreConfiguration.CONF_TBL_PREFIX, "rya_");
            Reporter: David W. Lotts
            Priority: Minor


These two constants[1][2] are somewhat redundant.  They are the the same as the Rya Instance in most cases.  For MongoDB, the table prefix[2] may be used incorrectly instead of the collection prefix[1].

They should probably be melded into one config key and method and be called the rya instance.  The RyaDetails has this concept.  There is a ConfigUtil.getTablePrefix() that should be refactored as part of this.

Some have suggested that the collection prefix is not needed at all since it is scoped inside a single Mongo Database which contains only one rya instance.

[1]  conf.set(MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX, "rya_");
[2]  conf.set(RdfCloudTripleStoreConfiguration.CONF_TBL_PREFIX, "rya_");

Some unit tests set them as different values.

Look at  extras/indexing/src/main/java/mvm/rya/sail/config/RyaSailFactory.java around line 73 for a good example of the confusion.  Look for this comment:
// XXX Should(?) be MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX inside the if below.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)