You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by jb...@apache.org on 2018/04/17 21:02:11 UTC
[geode-native] branch develop updated: GEODE-4410: Fixes unused
parameter in DistributedSystem::connect
This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new a0c770b GEODE-4410: Fixes unused parameter in DistributedSystem::connect
a0c770b is described below
commit a0c770b752b4088d259a522f8d829f9b209509be
Author: Jacob Barrett <jb...@pivotal.io>
AuthorDate: Tue Apr 17 13:56:07 2018 -0700
GEODE-4410: Fixes unused parameter in DistributedSystem::connect
---
cppcache/include/geode/DistributedSystem.hpp | 2 +-
cppcache/integration-test/testConnect.cpp | 2 +-
cppcache/src/CacheImpl.cpp | 2 +-
cppcache/src/DistributedSystem.cpp | 2 +-
cppcache/src/DistributedSystemImpl.cpp | 2 +-
cppcache/src/DistributedSystemImpl.hpp | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/cppcache/include/geode/DistributedSystem.hpp b/cppcache/include/geode/DistributedSystem.hpp
index 0242219..7413ecc 100644
--- a/cppcache/include/geode/DistributedSystem.hpp
+++ b/cppcache/include/geode/DistributedSystem.hpp
@@ -78,7 +78,7 @@ class APACHE_GEODE_EXPORT DistributedSystem {
* @brief connects from the distributed system
* @throws AlreadyConnectedException if this call has succeeded once before
*/
- void connect(Cache* cache);
+ void connect();
/**
* @brief disconnect from the distributed system
diff --git a/cppcache/integration-test/testConnect.cpp b/cppcache/integration-test/testConnect.cpp
index ea26013..9d42478 100644
--- a/cppcache/integration-test/testConnect.cpp
+++ b/cppcache/integration-test/testConnect.cpp
@@ -26,7 +26,7 @@ DUNIT_TASK(s1p1, CreateRegionOne)
auto factory = CacheFactory();
auto cache = std::make_shared<Cache>(factory.create());
try {
- cache->getDistributedSystem().connect(cache.get());
+ cache->getDistributedSystem().connect();
FAIL("Expected an exception.");
} catch (const AlreadyConnectedException& ex) {
LOG("Got expected exception.");
diff --git a/cppcache/src/CacheImpl.cpp b/cppcache/src/CacheImpl.cpp
index 549960d..a365adc 100644
--- a/cppcache/src/CacheImpl.cpp
+++ b/cppcache/src/CacheImpl.cpp
@@ -110,7 +110,7 @@ CacheImpl::CacheImpl(Cache* c, const std::shared_ptr<Properties>& dsProps,
throw;
}
- m_distributedSystem.connect(m_cache);
+ m_distributedSystem.connect();
}
void CacheImpl::initServices() {
diff --git a/cppcache/src/DistributedSystem.cpp b/cppcache/src/DistributedSystem.cpp
index 380c28d..1848507 100644
--- a/cppcache/src/DistributedSystem.cpp
+++ b/cppcache/src/DistributedSystem.cpp
@@ -102,7 +102,7 @@ DistributedSystem DistributedSystem::create(
return distributedSystem;
}
-void DistributedSystem::connect(Cache* cache) { m_impl->connect(cache); }
+void DistributedSystem::connect() { m_impl->connect(); }
void DistributedSystem::disconnect() { m_impl->disconnect(); }
diff --git a/cppcache/src/DistributedSystemImpl.cpp b/cppcache/src/DistributedSystemImpl.cpp
index 982b286..97e667a 100644
--- a/cppcache/src/DistributedSystemImpl.cpp
+++ b/cppcache/src/DistributedSystemImpl.cpp
@@ -54,7 +54,7 @@ DistributedSystemImpl::~DistributedSystemImpl() {
LOGFINE("Destroyed DistributedSystemImpl");
}
-void DistributedSystemImpl::connect(Cache* cache) {
+void DistributedSystemImpl::connect() {
if (m_connected == true) {
throw AlreadyConnectedException(
"DistributedSystem::connect: already connected, call getInstance to "
diff --git a/cppcache/src/DistributedSystemImpl.hpp b/cppcache/src/DistributedSystemImpl.hpp
index 7eac4e8..8c03781 100644
--- a/cppcache/src/DistributedSystemImpl.hpp
+++ b/cppcache/src/DistributedSystemImpl.hpp
@@ -76,7 +76,7 @@ class APACHE_GEODE_EXPORT DistributedSystemImpl {
/** Retrieve the MemberId used to create this Cache. */
virtual void disconnect();
- virtual void connect(Cache* cache);
+ virtual void connect();
void logSystemInformation() const;
--
To stop receiving notification emails like this one, please contact
jbarrett@apache.org.