You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/06/15 21:20:13 UTC
[GitHub] [airflow] hussein-awala opened a new pull request, #31946: Fix number param html type in trigger template
hussein-awala opened a new pull request, #31946:
URL: https://github.com/apache/airflow/pull/31946
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
related: #31930
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #31946: Fix number param html type in trigger template
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #31946:
URL: https://github.com/apache/airflow/pull/31946#discussion_r1232025231
##########
tests/models/test_param.py:
##########
@@ -167,8 +167,8 @@ def test_number_param(self):
p = Param(42, type="number")
assert p.resolve() == 42
- p = Param(1.0, type="number")
- assert p.resolve() == 1.0
+ p = Param(1.2, type="number")
+ assert p.resolve() == 1.2
Review Comment:
:heart:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31946: Fix number param html type in trigger template
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31946:
URL: https://github.com/apache/airflow/pull/31946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #31946: Fix number param html type in trigger template
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #31946:
URL: https://github.com/apache/airflow/pull/31946#discussion_r1231763172
##########
tests/models/test_param.py:
##########
@@ -167,8 +167,8 @@ def test_number_param(self):
p = Param(42, type="number")
assert p.resolve() == 42
- p = Param(1.0, type="number")
- assert p.resolve() == 1.0
+ p = Param(1.2, type="number")
+ assert p.resolve() == 1.2
Review Comment:
Good idea, since `1.0 == 1` in Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #31946: Fix number param html type in trigger template
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #31946:
URL: https://github.com/apache/airflow/pull/31946#discussion_r1231547864
##########
tests/models/test_param.py:
##########
@@ -167,8 +167,8 @@ def test_number_param(self):
p = Param(42, type="number")
assert p.resolve() == 42
- p = Param(1.0, type="number")
- assert p.resolve() == 1.0
+ p = Param(1.2, type="number")
+ assert p.resolve() == 1.2
Review Comment:
I am not sure that I need to update it, but using 1.2 is more significant that 1.0 to prove that `number` type accept float values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org