[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

[GitBox <gi...@apache.org>]

onichols-pivotal commented on a change in pull request #5427:
URL: https://github.com/apache/geode/pull/5427#discussion_r466006536



##########
File path: ci/scripts/delete_instance.sh
##########
@@ -29,6 +29,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symli
 done
 SCRIPTDIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
 
+. ${SCRIPTDIR}/short_circuit_pr_tasks.sh
+cd geode
+  is_source_from_pr_testable "ci" "dev-tools" "etc" "geode-book" "geode-docs" || exit 0

Review comment:
       what about README.md, LICENSE, or NOTICE in the top level? or other LICENSE/NOTICE files?

##########
File path: ci/scripts/execute_tests.sh
##########
@@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then
   exit 1
 fi
 
+. ${SCRIPTDIR}/short_circuit_pr_tasks.sh
+cd geode
+  is_source_from_pr_testable "ci" "dev-tools" "etc" "geode-book" "geode-docs" || exit 0

Review comment:
       any way to avoid duplicating this list two places?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org