[jira] [Commented] (ONAMI-111) Prefer JSR-330 classes

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ONAMI-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059987#comment-14059987 ] 

Hudson commented on ONAMI-111:
------------------------------

FAILURE: Integrated in Onami-Scheduler #463 (See [https://builds.apache.org/job/Onami-Scheduler/463/])
ONAMI-111 Prefer JSR-330 classes (ash2k: rev 1610111)
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/configuration/example/commons/general/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/configuration/example/commons/plist/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/configuration/example/map/dynamic/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/configuration/example/map/general/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/configuration/example/map/lazy/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/configuration/example/map/named/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/integrations/example/rocoto/ExampleImpl.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/scanner/asm/example/autobind/marker/FirstMarker.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/scanner/asm/example/autobind/marker/SecondMarker.java
* /onami/trunk/autobind/examples/src/main/java/org/apache/onami/autobind/scanner/asm/example/autobind/multiple/ExampleContainer.java
* /onami/trunk/autobind/integrations/metro/src/main/java/org/apache/onami/autobind/integrations/metro/InjectorProvider.java
* /onami/trunk/converters/net/src/test/java/org/apache/onami/converters/net/URLConverterTestCase.java
* /onami/trunk/lifecycle/core/src/test/java/org/apache/onami/lifecycle/core/MultiLifeCycleObject.java
* /onami/trunk/lifecycle/core/src/test/java/org/apache/onami/lifecycle/core/MultiLifeCycleTestCase.java
* /onami/trunk/lifecycle/core/src/test/java/org/apache/onami/lifecycle/core/StageObject1.java
* /onami/trunk/lifecycle/core/src/test/java/org/apache/onami/lifecycle/core/StageObject2.java
* /onami/trunk/lifecycle/standard/src/test/java/org/apache/onami/lifecycle/standard/DisposeTestCase.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/Dag1.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/Dag2.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/Dag3.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/Dag4.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/Flat.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/Recorder.java
* /onami/trunk/lifecycle/warmup/src/test/java/org/apachi/onami/lifecycle/warmup/RecorderSleepSettings.java
* /onami/trunk/logging/testframework/src/main/java/org/apache/onami/logging/testfw/AbstractLoggerInectionTestCase.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/AllPersistenceUnits.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/AnnotatedPersistenceUnitBuilder.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/ApplicationManagedEntityManagerFactoryProvider.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/ContainerManagedEntityManagerFactoryProvider.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/EntityManagerFactoryFactory.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/EntityManagerFactorySourceByJndiLookup.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/EntityManagerFactorySourceViaProvider.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/EntityManagerProvider.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/EntityManagerProviderImpl.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/ForApplicationManaged.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/ForContainerManaged.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/JndiLookupHelper.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/JtaTransactionFacadeFactory.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/PersistenceFilterImpl.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/PersistenceModule.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/PersistenceUnitModule.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/PersistenceUnitModuleConfiguration.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/ResourceLocalTransactionFacadeFactory.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/Transactional.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/TransactionalAnnotationHelper.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/TransactionalAnnotationReader.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/TxnInterceptor.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/UserTransactionFacade.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/UserTransactionJndiName.java
* /onami/trunk/persist/src/main/java/org/apache/onami/persist/UserTransactionProviderByJndiLookup.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/EntityManagerFactorySourceViaProviderTest.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/PersistenceUnitModuleConfigurationTest.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/test/UnderstandRequestInjectionTest.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/test/multipersistenceunits/FirstPU.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/test/multipersistenceunits/SecondPU.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/test/multipersistenceunits/TransactionalMultiplePuTest.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/test/transaction/testframework/TransactionalTask.java
* /onami/trunk/persist/src/test/java/org/apache/onami/persist/test/transaction/testframework/TransactionalWorker.java
* /onami/trunk/scheduler/src/test/java/org/apache/onami/scheduler/GuartzSimpleTriggerTimerTestCase.java
* /onami/trunk/scheduler/src/test/java/org/apache/onami/scheduler/RepeatedSchedulingTestCase.java
* /onami/trunk/scopes/src/main/java/org/apache/onami/scopes/ConcurrentLazySingleton.java
* /onami/trunk/scopes/src/main/java/org/apache/onami/scopes/LazySingleton.java
* /onami/trunk/scopes/src/test/java/org/apache/onami/scopes/TestConcurrentLazySingleton.java
* /onami/trunk/scopes/src/test/java/org/apache/onami/scopes/TestLazySingleton.java
* /onami/trunk/spi/modules/src/test/java/org/apache/onami/spi/modules/GuiceServiceLoaderTestCase.java
* /onami/trunk/spi/services/src/test/java/org/apache/onami/spi/services/BarBindingAnnotation.java
* /onami/trunk/spi/services/src/test/java/org/apache/onami/spi/services/FromSystemPropertiesTestCase.java
* /onami/trunk/spi/services/src/test/java/org/apache/onami/spi/services/ServiceLoaderModuleTestCase.java
* /onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java
* /onami/trunk/test/src/main/java/org/apache/onami/test/OnamiSuite.java
* /onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceInjectableClassHandler.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/InjectDependingMockObjectTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/InjectFromSuperClassTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/InjectMockObjectTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/InjectModuleClassTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/InjectStaticSimpleTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/MockitoFrameworkTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/SimpleTest.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/data/HelloWordAnnotated.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/data/HelloWorld.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/data/TestAnnotation.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/data/TestAnnotation2.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/guice/MockAnnotatedWithTestCase.java
* /onami/trunk/test/src/test/java/org/apache/onami/test/guice/TestCustomInjectionTest.java


> Prefer JSR-330 classes
> ----------------------
>
>                 Key: ONAMI-111
>                 URL: https://issues.apache.org/jira/browse/ONAMI-111
>             Project: Apache Onami
>          Issue Type: Improvement
>          Components: autobind, converters, lifecycle, logging, persist, scheduler, scopes, spi, test
>            Reporter: Mikhail Mazursky
>            Assignee: Mikhail Mazursky
>            Priority: Minor
>
> As per [Guice's documentation|https://github.com/google/guice/wiki/JSR330#best-practices], JSR-330 annotations and interfaces are preffered to those bundled with Guice.



--
This message was sent by Atlassian JIRA
(v6.2#6252)