You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/04/26 22:11:03 UTC
[jira] [Commented] (QPID-3227) rdma layer may allow overrun of send
buffers
[ https://issues.apache.org/jira/browse/QPID-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025407#comment-13025407 ]
jiraposter@reviews.apache.org commented on QPID-3227:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/667/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Gordon Sim, and Chug Rolke.
Summary
-------
Prevents buffer overflow bug by explicitly allowing RdmaIO layer to reserve header space in send buffers.
This addresses bug QPID-3227.
https://issues.apache.org/jira/browse/QPID-3227
Diffs
-----
/trunk/qpid/cpp/src/qpid/sys/rdma/RdmaIO.cpp 1096872
/trunk/qpid/cpp/src/qpid/sys/rdma/rdma_wrap.h 1096872
/trunk/qpid/cpp/src/qpid/sys/rdma/rdma_wrap.cpp 1096872
Diff: https://reviews.apache.org/r/667/diff
Testing
-------
unit tests & scale testing (by hand using perftest).
Thanks,
Kenneth
> rdma layer may allow overrun of send buffers
> --------------------------------------------
>
> Key: QPID-3227
> URL: https://issues.apache.org/jira/browse/QPID-3227
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.10
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.11
>
> Attachments: QPID-3227.patch
>
>
> The rdma driver adds a small trailer to outbound buffers, however the size of this header is not accounted for when the buffer's size is passed to the codec. If the codec fills all available buffer space, the rdma driver will overwrite the end of the buffer when adding the trailer.
> Kudos to Chuck Rolke for helping root-cause this bug!
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org