You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/11 06:30:12 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #38200: [SPARK-40743][CONNECT] StructType should contain a list of StructField and each field should have a name
cloud-fan commented on code in PR #38200:
URL: https://github.com/apache/spark/pull/38200#discussion_r991863876
##########
connector/connect/src/main/protobuf/spark/connect/types.proto:
##########
@@ -167,8 +167,14 @@ message DataType {
Nullability nullability = 4;
}
+ message StructField {
+ DataType type = 1;
+ string name = 2;
+ Nullability nullability = 3;
Review Comment:
isn't Nullability just a boolean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org