You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/05 17:11:00 UTC

[jira] [Commented] (FLINK-10064) Fix a typo in ExternalCatalogTable

    [ https://issues.apache.org/jira/browse/FLINK-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569518#comment-16569518 ] 

ASF GitHub Bot commented on FLINK-10064:
----------------------------------------

tragicjun opened a new pull request #6497: [FLINK-10064] [table] Fix a typo in ExternalCatalogTable
URL: https://github.com/apache/flink/pull/6497
 
 
   ## What is the purpose of the change
   
   Function **ExternalCatalogTable.IsTableSink** should return **isSink** not **isSource**, I guess it was a small typo.
   
   ## Brief change log
   
   - ExternalCatalogTable.IsTableSink returns isSink instead of isSource
   
   ## Verifying this change
   
   This change is a trivial typo fix without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix a typo in ExternalCatalogTable
> ----------------------------------
>
>                 Key: FLINK-10064
>                 URL: https://issues.apache.org/jira/browse/FLINK-10064
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.0
>            Reporter: Jun Zhang
>            Assignee: Jun Zhang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Function *ExternalCatalogTable.IsTableSink* should return *isSink* not *isSource*, I guess it was a small typo:
> {code:java}
> def isTableSink: Boolean = {
>  isSource
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)