You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 04:21:40 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

WeiZhong94 opened a new pull request #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659
 
 
   ## What is the purpose of the change
   
   *FileUtils#compressDirectory behaves buggy when processing relative directory path. If the path of target directory is a relative path, the relative path inside the target zip file can not be constructed correctly. Convert the relative path to absolute path before compressing it.*
   
   
   ## Brief change log
   
     - *Convert the relative path to absolute path before compressing it.*
     - *Add test for the change.*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *FileUtilsTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW merged pull request #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659#issuecomment-568353302
 
 
   <!--
   Meta data
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142075152 TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3850 TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   -->
   ## CI report:
   
   * c844fea56756ed6b6101fc8d976ab0357b6f637b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142075152) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3850) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhijiangW commented on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659#issuecomment-568698939
 
 
   backport from #10570 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659#issuecomment-568349445
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c844fea56756ed6b6101fc8d976ab0357b6f637b (Mon Dec 23 04:23:39 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659#issuecomment-568353302
 
 
   <!--
   Meta data
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142075152 TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3850 TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   -->
   ## CI report:
   
   * c844fea56756ed6b6101fc8d976ab0357b6f637b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142075152) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3850) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659#issuecomment-568353302
 
 
   <!--
   Meta data
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   -->
   ## CI report:
   
   * c844fea56756ed6b6101fc8d976ab0357b6f637b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10659: [FLINK-15248][FileSystems] Allow FileUtils#compressDirectory to process relative directories.
URL: https://github.com/apache/flink/pull/10659#issuecomment-568353302
 
 
   <!--
   Meta data
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142075152 TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   Hash:c844fea56756ed6b6101fc8d976ab0357b6f637b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3850 TriggerType:PUSH TriggerID:c844fea56756ed6b6101fc8d976ab0357b6f637b
   -->
   ## CI report:
   
   * c844fea56756ed6b6101fc8d976ab0357b6f637b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142075152) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3850) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services