[GitHub] [tinkerpop] spmallette commented on pull request #1400: TINKERPOP-2530: Transfer OyvindSabo/gremlint to apache/tinkerpop/gremlint

[GitBox <gi...@apache.org>]

spmallette commented on pull request #1400:
URL: https://github.com/apache/tinkerpop/pull/1400#issuecomment-807614370


   > I'll update this PR to place just the gremlint library code in tinkerpop/gremlint, rather than placing the library code under tinkerpop/gremlint/gremlint and the wep page code under tinkerpop/gremlint/gremlint.com as I've done currently.
   
   yeah - i think that makes sense. ultimately i think we'll push the gremlint.com stuff to a directory here given that discussion with infra: 
   
   https://github.com/apache/tinkerpop/tree/master/docs/site/home
   
   > That way I can more easily start looking into how the library would be included in the Maven build structure, without doing a lot of temporary work which will need to change upon a future folder structure change. It will also let me remove some apache-rat-plugin entries in pom.xml I added for gremlint.com files in which I could not put an Apache license.
   
   I'd like to see this PR get merged in time for 3.5.0 which i would like to see release in April. For 3.5.0 it would be enough for me to see the code in the repo and http://tinkerpop.apache.org/gremlint (or whatever it is) active. Perhaps we just focus on that much for this initial PR and then you can do additional maven build structure related work at a later point after it's merged. If that work makes it to 3.5.0, great! if not, no worries/no pressure. does that make sense to you?
   
   > Question: When adding the gremlint.com code to this PR I made some updates like adding a few missing license headers and some README mistakes I noticed. Would it be okay to push those changes to the OyvindSabo/gremlint.com repository before it gets transferred to Apache, or does the latest commit hash have to match the one in the gremlint IP Clearance document? If so, would it be cumbersome to update those at this point?
   
   I'm not sure about the hash to be honest. Let's try to keep the initial commit aligned to what was in the IP Clearance document. Feel free to just move things around as needed in this PR.  If we don't like the extended commit history we can just squash everything down to two commits before merge, your initial one and then your changes that came afterwords. As this is all new code it shouldn't create merge conflicts or any hassles to worry about that I can think of. sound good?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org