[GitHub] [spark] maropu commented on a change in pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r512494277



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
   override def hashCode(): Int = getClass.hashCode()
 
   override def equals(other: Any): Boolean = other match {
-    case that: UserDefinedType[_] => this.acceptsType(that)
+    case that: UserDefinedType[_] => this.getClass == other.getClass

Review comment:
       This update comes from https://github.com/apache/spark/commit/0ec17c989debddb56a8048e4bd29ae666e4d9c56. I'm currently checking the python test results.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org