You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/10/02 11:13:37 UTC

svn commit: r1893807 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function: PDFunction.java PDFunctionType2.java

Author: tilman
Date: Sat Oct  2 11:13:37 2021
New Revision: 1893807

URL: http://svn.apache.org/viewvc?rev=1893807&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov; make method final that is called in constructor

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunctionType2.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java?rev=1893807&r1=1893806&r2=1893807&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java Sat Oct  2 11:13:37 2021
@@ -82,7 +82,7 @@ public abstract class PDFunction impleme
      * @return The stream for this object.
      */
     @Override
-    public COSDictionary getCOSObject()
+    public final COSDictionary getCOSObject()
     {
         if (functionStream != null)
         {

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunctionType2.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunctionType2.java?rev=1893807&r1=1893806&r2=1893807&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunctionType2.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunctionType2.java Sat Oct  2 11:13:37 2021
@@ -54,9 +54,10 @@ public class PDFunctionType2 extends PDF
     {
         super(function);
 
-        if (getCOSObject().getDictionaryObject(COSName.C0) instanceof COSArray)
+        COSArray cosArray0 = getCOSObject().getCOSArray(COSName.C0);
+        if (cosArray0 != null)
         {
-            c0 = getCOSObject().getCOSArray(COSName.C0);
+            c0 = cosArray0;
         }
         else
         {
@@ -67,9 +68,10 @@ public class PDFunctionType2 extends PDF
             c0.add(new COSFloat(0));
         }
 
-        if (getCOSObject().getDictionaryObject(COSName.C1) instanceof COSArray)
+        COSArray cosArray1 = getCOSObject().getCOSArray(COSName.C1);
+        if (cosArray1 != null)
         {
-            c1 = getCOSObject().getCOSArray(COSName.C1);
+            c1 = cosArray1;
         }
         else
         {