You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/11 09:33:59 UTC

[GitHub] [skywalking] Zhannan3 opened a new issue, #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Zhannan3 opened a new issue, #9950:
URL: https://github.com/apache/skywalking/issues/9950

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   Java Agent (apache/skywalking-java)
   
   ### What happened
   
   If the run() methods Code in
   
   notify(GRPCChannelStatus.CONNECTED);
   reconnectCount = 0;
   reconnect = false;
   
   And reportError (Throwable Throwable) methods
   
   if (isNetworkError(throwable)) {
     reconnect = true;
     notify(GRPCChannelStatus.DISCONNECT);
   }
   
   The code is run simultaneously, but in the order
   
   notify(GRPCChannelStatus.CONNECTED);
   reconnectCount = 0;
   reconnect = true;
   notify(GRPCChannelStatus.DISCONNECT);
   reconnect = false;
   
   Will appear
   GRPCChannelStatus equals DISCONNECT
   reconnect = false;
   As a result, run() in GRPCChannelManager cannot establish a link again,Agent will no longer report information
   
   ### What you expected to happen
   
   GRPCChannelStatus equals DISCONNECT
   reconnect = false;
   As a result, run() in GRPCChannelManager cannot establish a link again,Agent will no longer report information
   
   ### How to reproduce
   
   run() method and reportError (Throwable Throwable) method run simultaneously
   
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Zhannan3 commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
Zhannan3 commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1312934105

   > I replied. The workflow mentioned is impossible for today's codes from my check. Please be clear about what you are asking.
   
   We use the Java agent version V8.13.0. When the Java agent and skywalking are not connected for a long time, and the probe attempts to link skywalking for many times without success, the probability of not trying to link skywalking again does appear. I think the answer in[ Apache/skywalking java # 290](https://github.com/apache/skywalking-java/pull/290) can solve our problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1312936986

   https://github.com/apache/skywalking-java/pull/290 is being used since 8.12, and 8.13 also includes the codes.
   I don't know why you mentioned 8.13.0 is not working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Zhannan3 commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
Zhannan3 commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1313032930

   > [apache/skywalking-java#290](https://github.com/apache/skywalking-java/pull/290) is being used since 8.12, and 8.13 also includes the codes. I don't know why you mentioned 8.13.0 is not working.
   
   sorry, I made a mistake,Our production line really uses 8.11.0, and the test uses 8.13.0. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1312920012

   You are asking about the agent, v9.2.0 is only a backend version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1311468630

   Which version are you talking about? I am feeling this had been fixed by https://github.com/apache/skywalking-java/pull/290 months ago.
   
   ```
   notify(GRPCChannelStatus.CONNECTED);
   reconnectCount = 0;
   reconnect = true;
   ```
   
   This is not going to be the execution order anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading
URL: https://github.com/apache/skywalking/issues/9950


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Zhannan3 commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
Zhannan3 commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1312917597

   > 你说的是哪个版本？我觉得这已经被[apache/skywalking-java#290](https://github.com/apache/skywalking-java/pull/290)个月前修复了。
   > 
   > ```
   > notify(GRPCChannelStatus.CONNECTED);
   > reconnectCount = 0;
   > reconnect = true;
   > ```
   > 
   > 这将不再是执行顺序。
   
   V9.2.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Zhannan3 commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
Zhannan3 commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1312926300

   > 您问的是代理，v9.2.0 只是一个后端版本。
   
   v8.13.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9950: [Bug] The reportError(Throwable throwable) method and run() method in GRPCChannelManager cannot be re linked due to multithreading

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9950:
URL: https://github.com/apache/skywalking/issues/9950#issuecomment-1312927098

   I replied. The workflow mentioned is impossible for today's codes from my check. Please be clear about what you are asking. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org