[GitHub] [netbeans] sdedic commented on a diff in pull request #5038: Proxy autodetection + autoconfiguration for Maven.

[GitBox <gi...@apache.org>]

sdedic commented on code in PR #5038:
URL: https://github.com/apache/netbeans/pull/5038#discussion_r1038035240


##########
java/maven/src/org/netbeans/modules/maven/problems/SanityBuildAction.java:
##########
@@ -97,6 +107,21 @@ public void run() {
                     String label = build_label(nbproject.getProjectDirectory().getNameExt());
                     config.setExecutionName(label);
                     config.setTaskDisplayName(label);
+                    
+                    MavenProxySupport mps = nbproject.getLookup().lookup(MavenProxySupport.class);
+                    if (mps != null) {
+                        ProxyResult res;

Review Comment:
   Hm, I'll better check the behaviour with 'cancel' in the dialog; thanks !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists