You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/17 21:17:37 UTC

[GitHub] merlimat opened a new pull request #1274: Ensure we instantiate threads that extend Netty FastThreadLocalThread

merlimat opened a new pull request #1274: Ensure we instantiate threads that extend Netty FastThreadLocalThread
URL: https://github.com/apache/bookkeeper/pull/1274
 
 
   Since we make heavy use of `Recycler` and other `FastThreadLocal` objects from Netty, we should make sure that all (critical) threads that we instantiate are inheriting from `FastThreadLocalThread`.
   
   `FastThreadLocalThread` has an optimization that makes access to `FastThreadLocal` faster. It's a class that extends regular `Thread` and adds a field for the thread local access.
   
   There are a couple of places where we're currently not using `FastThreadLocal`: 
    * `OrderedScheduler` builder
    * `BookieThread` (which is used in `Journal`, `ForceSyncThread`, etc..)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services