You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/06 08:54:39 UTC
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #711: doc: fix deploy doc
juzhiyuan commented on a change in pull request #711:
URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r518606469
##########
File path: docs/deploy.md
##########
@@ -114,18 +113,15 @@ $ api/run.sh &
## Configuration
-1. `conf.dag-lib-path` MUST use absolute path, we could use `pwd` command. Only used when enable Plugin Orchestration.
+1. `conf.listen.host` is set to `127.0.0.1` so we could only visit it in private, we could change it to `0.0.0.0` to allow any visitors.
-2. `conf.listen.host` is set to `127.0.0.1` so we could only visit it in private, we could change it to `0.0.0.0` to allow any visitors.
-
-3. `conf.etcd.endpoints` is used to set ETCD's instances address, it supports multiple instances mode.
+2. `conf.etcd.endpoints` is used to set ETCD's instances address, it supports multiple instances mode.
```json
-{
- "etcd": {
- "endpoints": "127.0.0.1:2379,127.0.0.1:3379"
- }
-}
+ etcd:
+ endpoints:
+ - 127.0.0.1:2379
+ - 127.0.0.1:3379
Review comment:
##########
File path: docs/deploy.md
##########
@@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`.
## Run
-1. According to your deploy environment, check the related configurations in `api/conf/conf.yaml`, modify those variables if needed.
+1. According to your deploy environment, check the related configurations in `output/conf/conf.yaml`, modify those variables if needed.
Review comment:
Why? The output folder is generated only when we run the shell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org