[GitHub] [samza] cameronlee314 opened a new pull request #1221: SAMZA-2388: [Scala cleanup] Convert Util to Java

[GitBox <gi...@apache.org>]

cameronlee314 opened a new pull request #1221: SAMZA-2388: [Scala cleanup] Convert Util to Java
URL: https://github.com/apache/samza/pull/1221
 
 
   Except for the case noted below, the intention of this PR is to not change any functionality. The intention is to just migrate logic to Java.
   
   https://github.com/apache/samza/pull/1199 intended to migrate `Util.rewriteConfig` to Java, but it also changed some functionality. That change applied each rewriter to the original config and then merged the results together. The original logic applied each rewriter to the rewritten result of the previous rewriter. Example cases where the overall rewritten result would be different: 1) one of the rewriters deletes a config (new code would do a merge so the config would not get deleted in the final result), 2) one rewriter depended on the result of another rewriter (new code would not allow rewriter to see results of previous rewriters)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services