You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/06/07 20:42:51 UTC

[GitHub] [incubator-tuweni] atoulme opened a new issue #256: Nit: Change WireConnection `agreedSubprotocol` to take a sub protocol identifier without a version

atoulme opened a new issue #256:
URL: https://github.com/apache/incubator-tuweni/issues/256


   WireConnection agreedSubProtocol should be "agreedSubprotocolVersion", and take "ETH" instead of "ETH65".
   
   Before:
   ```conn.agreedSubprotocol(EthSubprotocol.ETH65)```
   After:
   ```conn.agreedSubprotocolVersion(EthSubprotocol.ETH)```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme closed issue #256: Nit: Change WireConnection `agreedSubprotocol` to take a sub protocol identifier without a version

Posted by GitBox <gi...@apache.org>.
atoulme closed issue #256:
URL: https://github.com/apache/incubator-tuweni/issues/256


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org