You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/13 12:30:55 UTC
[GitHub] [pulsar] imryao opened a new pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
imryao opened a new pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271
Fixes: [#682](https://github.com/apache/pulsar-client-go/issues/682)
### Motivation
There's not much documentation of Prometheus metrics for pulsar go client.
### Modifications
This pull request add documentation and necessary examples of Prometheus metrics for pulsar go client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#issuecomment-992431897
@imryao:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] imryao commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
imryao commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768285184
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
Review comment:
@wolfstudy @Anonymitaet Thanks for your suggestions! I'll separate the code examples and add some description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] imryao commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
imryao commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768286281
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
Review comment:
I think `promhttp` is created by Prometheus module?
I found the demo at Prometheus official docs.
FYI: https://prometheus.io/docs/guides/go-application/#adding-your-own-metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768280413
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
Review comment:
@imryao thanks for adding docs.
To allow users better understand the purpose of this part, can you add some explanations/context before the code example? For example, `what does the example do?`, `Are there any considerations that need to take into account when using Prometheus metrics in Go SDK?`, etc.
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
Review comment:
@imryao +1 for separating code examples to each part (producer and consumer)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768455111
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
Review comment:
```suggestion
Pulsar Go client registers client metrics using Prometheus. This section demonstrates how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
```
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
+
+First, write a simple producer application:
Review comment:
```suggestion
1. Write a simple producer application.
```
Reason for this change: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.yoetnldi5amd
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
+
+First, write a simple producer application:
+
+```go
+// Create a pulsar client
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+// Start a separate goroutine for Prometheus metrics
+// In this case, Prometheus metrics can be accessed via http://localhost:2112/metrics
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
+ err = http.ListenAndServe(":"+strconv.Itoa(prometheusPort), nil)
+ if err != nil {
+ log.Fatal(err)
+ }
+}()
+
+// Create a producer
+producer, err := client.CreateProducer(pulsar.ProducerOptions{
+ Topic: "topic-1",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer producer.Close()
+
+ctx := context.Background()
+
+// Write your business logic here
+// In this case, we build a simple web server. You can produce a message by requesting http://localhost:8082/produce
+webPort := 8082
+http.HandleFunc("/produce", func(w http.ResponseWriter, r *http.Request) {
+ msgId, err := producer.Send(ctx, &pulsar.ProducerMessage{
+ Payload: []byte(fmt.Sprintf("hello world")),
+ })
+ if err != nil {
+ log.Fatal(err)
+ } else {
+ log.Printf("Published message: %v", msgId)
+ fmt.Fprintf(w, "Published message: %v", msgId)
+ }
+})
+
+err = http.ListenAndServe(":"+strconv.Itoa(webPort), nil)
+if err != nil {
+ log.Fatal(err)
+}
+```
+
+Then configure a locally running Prometheus instance to scrape metrics from the application with the following `prometheus.yml`:
Review comment:
```suggestion
2. To scrape metrics from applications, configure a local running Prometheus instance using a configuration file (`prometheus.yml`).
```
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
+
+First, write a simple producer application:
+
+```go
+// Create a pulsar client
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+// Start a separate goroutine for Prometheus metrics
+// In this case, Prometheus metrics can be accessed via http://localhost:2112/metrics
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
+ err = http.ListenAndServe(":"+strconv.Itoa(prometheusPort), nil)
+ if err != nil {
+ log.Fatal(err)
+ }
+}()
+
+// Create a producer
+producer, err := client.CreateProducer(pulsar.ProducerOptions{
+ Topic: "topic-1",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer producer.Close()
+
+ctx := context.Background()
+
+// Write your business logic here
+// In this case, we build a simple web server. You can produce a message by requesting http://localhost:8082/produce
+webPort := 8082
+http.HandleFunc("/produce", func(w http.ResponseWriter, r *http.Request) {
+ msgId, err := producer.Send(ctx, &pulsar.ProducerMessage{
+ Payload: []byte(fmt.Sprintf("hello world")),
+ })
+ if err != nil {
+ log.Fatal(err)
+ } else {
+ log.Printf("Published message: %v", msgId)
+ fmt.Fprintf(w, "Published message: %v", msgId)
+ }
+})
+
+err = http.ListenAndServe(":"+strconv.Itoa(webPort), nil)
+if err != nil {
+ log.Fatal(err)
+}
+```
+
+Then configure a locally running Prometheus instance to scrape metrics from the application with the following `prometheus.yml`:
+
+```yaml
+scrape_configs:
+- job_name: pulsar-client-go-metrics
+ scrape_interval: 10s
+ static_configs:
+ - targets:
+ - localhost:2112
+```
+
+Finally, you can query pulsar client metrics on Prometheus!
Review comment:
```suggestion
Now you can query Pulsar client metrics on Prometheus.
```
Reason for this change: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.6ugxq52wtpf1
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -564,6 +638,68 @@ if err != nil {
defer consumer.Close()
```
+#### How to use Prometheus metrics in consumer
+
+In this guide, we'll show you how to create a simple Pulsar consumer application that exposes Prometheus metrics via HTTP.
Review comment:
same comment
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
+
+First, write a simple producer application:
+
+```go
+// Create a pulsar client
Review comment:
```suggestion
// Create a Pulsar client
```
Reason for this change: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.1oxiv9hq05mn
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -564,6 +638,68 @@ if err != nil {
defer consumer.Close()
```
+#### How to use Prometheus metrics in consumer
+
+In this guide, we'll show you how to create a simple Pulsar consumer application that exposes Prometheus metrics via HTTP.
+
Review comment:
```suggestion
1. Write a simple consumer application.
```
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -564,6 +638,68 @@ if err != nil {
defer consumer.Close()
```
+#### How to use Prometheus metrics in consumer
+
+In this guide, we'll show you how to create a simple Pulsar consumer application that exposes Prometheus metrics via HTTP.
+
+```go
+// Create a pulsar client
Review comment:
same
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
Review comment:
Reason for this change: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.gfwms5zehcak
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,80 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+Pulsar Go client registers client metrics using Prometheus. In this guide, we'll show you how to create a simple Pulsar producer application that exposes Prometheus metrics via HTTP.
+
+First, write a simple producer application:
+
+```go
+// Create a pulsar client
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+// Start a separate goroutine for Prometheus metrics
+// In this case, Prometheus metrics can be accessed via http://localhost:2112/metrics
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
+ err = http.ListenAndServe(":"+strconv.Itoa(prometheusPort), nil)
+ if err != nil {
+ log.Fatal(err)
+ }
+}()
+
+// Create a producer
+producer, err := client.CreateProducer(pulsar.ProducerOptions{
+ Topic: "topic-1",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer producer.Close()
+
+ctx := context.Background()
+
+// Write your business logic here
+// In this case, we build a simple web server. You can produce a message by requesting http://localhost:8082/produce
Review comment:
```suggestion
// In this case, you build a simple Web server. You can produce messages by requesting http://localhost:8082/produce
```
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -564,6 +638,68 @@ if err != nil {
defer consumer.Close()
```
+#### How to use Prometheus metrics in consumer
+
+In this guide, we'll show you how to create a simple Pulsar consumer application that exposes Prometheus metrics via HTTP.
+
+```go
+// Create a pulsar client
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+// Start a separate goroutine for Prometheus metrics
+// In this case, Prometheus metrics can be accessed via http://localhost:2112/metrics
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
+ err = http.ListenAndServe(":"+strconv.Itoa(prometheusPort), nil)
+ if err != nil {
+ log.Fatal(err)
+ }
+}()
+
+// Create a consumer
+consumer, err := client.Subscribe(pulsar.ConsumerOptions{
+ Topic: "topic-1",
+ SubscriptionName: "sub-1",
+ Type: pulsar.Shared,
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer consumer.Close()
+
+ctx := context.Background()
+
+// Write your business logic here
+// In this case, we build a simple web server. You can consume a message by requesting http://localhost:8083/consume
+webPort := 8083
+http.HandleFunc("/consume", func(w http.ResponseWriter, r *http.Request) {
+ msg, err := consumer.Receive(ctx)
+ if err != nil {
+ log.Fatal(err)
+ } else {
+ log.Printf("Received message msgId: %v -- content: '%s'\n", msg.ID(), string(msg.Payload()))
+ fmt.Fprintf(w, "Received message msgId: %v -- content: '%s'\n", msg.ID(), string(msg.Payload()))
+ consumer.Ack(msg)
+ }
+})
+
+err = http.ListenAndServe(":"+strconv.Itoa(webPort), nil)
+if err != nil {
+ log.Fatal(err)
+}
+```
+
+The configuration of Prometheus instance is the same as we introduced in [producer metrics section](#how-to-use-prometheus-metrics-in-producer).
Review comment:
-----
2. To scrape metrics from applications, configure a local running Prometheus instance using a configuration file (`prometheus.yml`).
```yaml
scrape_configs:
- job_name: pulsar-client-go-metrics
scrape_interval: 10s
static_configs:
- targets:
- localhost:2112
```
Now you can query Pulsar client metrics on Prometheus.
----
I suggest "repeating" the steps here since it is quite simple and convenient for users to read it over.
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -564,6 +638,68 @@ if err != nil {
defer consumer.Close()
```
+#### How to use Prometheus metrics in consumer
+
+In this guide, we'll show you how to create a simple Pulsar consumer application that exposes Prometheus metrics via HTTP.
+
+```go
+// Create a pulsar client
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+// Start a separate goroutine for Prometheus metrics
+// In this case, Prometheus metrics can be accessed via http://localhost:2112/metrics
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
+ err = http.ListenAndServe(":"+strconv.Itoa(prometheusPort), nil)
+ if err != nil {
+ log.Fatal(err)
+ }
+}()
+
+// Create a consumer
+consumer, err := client.Subscribe(pulsar.ConsumerOptions{
+ Topic: "topic-1",
+ SubscriptionName: "sub-1",
+ Type: pulsar.Shared,
+})
+if err != nil {
+ log.Fatal(err)
+}
+
+defer consumer.Close()
+
+ctx := context.Background()
+
+// Write your business logic here
+// In this case, we build a simple web server. You can consume a message by requesting http://localhost:8083/consume
Review comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768276578
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: "pulsar://localhost:6650",
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+
+defer client.Close()
+
+go func() {
+ prometheusPort := 2112
+ log.Printf("Starting Prometheus metrics at http://localhost:%v/metrics\n", prometheusPort)
+ http.Handle("/metrics", promhttp.Handler())
Review comment:
How was `promhttp` created?
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
Review comment:
Thanks @imryao work for this, good patch.
This title looks inconsistent with the content, what about `How to use Prometheus metrics in Go SDK`? Or It is best that we can separate the code examples of producer and consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#issuecomment-993110318
@imryao @wolfstudy since this PR updates docs, please label it with `doc` rather than other labels, thanks.
`doc-required` means this PR needs to update docs and will update docs later.
`doc-added` means docs have been updated for this **code** PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] imryao commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
imryao commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768403138
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
Review comment:
I've separated the code examples and added some description. Looking forward to your further advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] imryao commented on a change in pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
imryao commented on a change in pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#discussion_r768404666
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -302,6 +302,91 @@ fmt.Println(msg.Payload())
canc()
```
+#### How to use Prometheus metrics in producer
+
Review comment:
Thanks for your advice! Context and description has been updated~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy merged pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] imryao commented on pull request #13271: [Docs] Add docs of prometheus metrics for pulsar go client
Posted by GitBox <gi...@apache.org>.
imryao commented on pull request #13271:
URL: https://github.com/apache/pulsar/pull/13271#issuecomment-993440029
Hi @Anonymitaet , thanks for your advice!
Your suggestions really make sense. I'll pay more attention to writing styles when committing changes on docs.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org