Clean checkbox on DIH

[Mahmoud Almokadem <pr...@gmail.com>]

Hello,

I'd like to request to uncheck the "Clean" checkbox by default on DIH page,
cause it cleaned the whole index about 2TB when I click Execute button by
wrong. Or show a confirmation message that the whole index will be cleaned!!

Sincerely,
Mahmoud

Re: Clean checkbox on DIH

[Rick Leir <rl...@leirtech.com>]

Mahmoud,
Would it help to have field validation? If the DIH fields are still default when you press execute, then field validation puts out a message and blocks any clearing. Just an idea, please excuse if I am off track. -- Rick

On May 2, 2017 8:53:12 AM EDT, Mahmoud Almokadem <pr...@gmail.com> wrote:
>Thanks Shawn for your clarifications,
>
>I think showing a confirmation message saying that "The whole index
>will be
>cleaned" when the clean option is checked will be good.
>
>I always remove the check from the file
>/opt/solr/server/solr-webapp/webapp/tpl/dataimport.html after
>installing
>solr but when I upgraded it this time forget to do that and press
>Execute
>with the check and the whole index cleaned.
>
>And for the dataimport I always use the old UI cause the new UI doesn't
>show the live update and sometimes doesn't show the configuration. I
>think
>there are many bugs on the new UI.
>
>Thanks,
>Mahmoud
>
>On Mon, May 1, 2017 at 4:30 PM, Shawn Heisey <ap...@elyograg.org>
>wrote:
>
>> On 4/28/2017 9:01 AM, Mahmoud Almokadem wrote:
>> > We already using a shell scripts to do our import and using
>fullimport
>> > command to do our delta import and everything is doing well several
>> > years ago. But default of the UI is full import with clean and
>commit.
>> > If I press the Execute button by mistake the whole index is cleaned
>> > without any notification.
>>
>> I understand your frustration.  What I'm worried about is the fallout
>if
>> we change the default to be unchecked, from people who didn't verify
>the
>> setting and expected full-import to wipe their index before it
>started
>> importing, just like it has always done for the last few years.
>>
>> The default value for the clean parameter when NOT using the admin UI
>is
>> true for full-import, and false for delta-import.  That's not going
>to
>> change.  I firmly believe that the admin UI should have the same
>> defaults as the API itself.  The very nature of a full-import carries
>> the implication that you want to start over with an empty index.
>>
>> What if there were some bright red text in the UI near the execute
>> button that urged you to double-check that the "clean" box has the
>> setting you want?  An alternate idea would be to pop up a yes/no
>> verification dialog on execute when the clean box is checked.
>>
>> Thanks,
>> Shawn
>>
>>

-- 
Sorry for being brief. Alternate email is rickleir at yahoo dot com 

Re: Clean checkbox on DIH

[Mahmoud Almokadem <pr...@gmail.com>]

Thanks Shawn,

We already use the admin UI for testing and bulk uploads. We are using curl
scripts for automation process.

I'll report the issues regarding the new UI on JIRA.

Thanks,
Mahmoud


On Tuesday, May 2, 2017, Shawn Heisey <ap...@elyograg.org> wrote:

> On 5/2/2017 6:53 AM, Mahmoud Almokadem wrote:
> > And for the dataimport I always use the old UI cause the new UI
> > doesn't show the live update and sometimes doesn't show the
> > configuration. I think there are many bugs on the new UI.
>
> Do you know if these problems have been reported in the Jira issue
> tracker?  The old UI is going to disappear in Solr 7.0 when it is
> released.  If there are bugs in the new UI, we need to have them
> reported so they can be fixed.
>
> As I stated earlier, when it comes to DIH, the admin UI is more useful
> for testing and research than actual usage.  The URLs for the admin UI
> cannot be used in automation tools -- the API must be used directly.
>
> Thanks,
> Shawn
>
>

Re: Clean checkbox on DIH

[Shawn Heisey <ap...@elyograg.org>]

On 5/2/2017 6:53 AM, Mahmoud Almokadem wrote:
> And for the dataimport I always use the old UI cause the new UI
> doesn't show the live update and sometimes doesn't show the
> configuration. I think there are many bugs on the new UI. 

Do you know if these problems have been reported in the Jira issue
tracker?  The old UI is going to disappear in Solr 7.0 when it is
released.  If there are bugs in the new UI, we need to have them
reported so they can be fixed.

As I stated earlier, when it comes to DIH, the admin UI is more useful
for testing and research than actual usage.  The URLs for the admin UI
cannot be used in automation tools -- the API must be used directly.

Thanks,
Shawn

Re: Clean checkbox on DIH

[Mahmoud Almokadem <pr...@gmail.com>]

Thanks Shawn for your clarifications,

I think showing a confirmation message saying that "The whole index will be
cleaned" when the clean option is checked will be good.

I always remove the check from the file
/opt/solr/server/solr-webapp/webapp/tpl/dataimport.html after installing
solr but when I upgraded it this time forget to do that and press Execute
with the check and the whole index cleaned.

And for the dataimport I always use the old UI cause the new UI doesn't
show the live update and sometimes doesn't show the configuration. I think
there are many bugs on the new UI.

Thanks,
Mahmoud

On Mon, May 1, 2017 at 4:30 PM, Shawn Heisey <ap...@elyograg.org> wrote:

> On 4/28/2017 9:01 AM, Mahmoud Almokadem wrote:
> > We already using a shell scripts to do our import and using fullimport
> > command to do our delta import and everything is doing well several
> > years ago. But default of the UI is full import with clean and commit.
> > If I press the Execute button by mistake the whole index is cleaned
> > without any notification.
>
> I understand your frustration.  What I'm worried about is the fallout if
> we change the default to be unchecked, from people who didn't verify the
> setting and expected full-import to wipe their index before it started
> importing, just like it has always done for the last few years.
>
> The default value for the clean parameter when NOT using the admin UI is
> true for full-import, and false for delta-import.  That's not going to
> change.  I firmly believe that the admin UI should have the same
> defaults as the API itself.  The very nature of a full-import carries
> the implication that you want to start over with an empty index.
>
> What if there were some bright red text in the UI near the execute
> button that urged you to double-check that the "clean" box has the
> setting you want?  An alternate idea would be to pop up a yes/no
> verification dialog on execute when the clean box is checked.
>
> Thanks,
> Shawn
>
>

Re: Clean checkbox on DIH

[Shawn Heisey <ap...@elyograg.org>]

On 4/28/2017 9:01 AM, Mahmoud Almokadem wrote:
> We already using a shell scripts to do our import and using fullimport
> command to do our delta import and everything is doing well several
> years ago. But default of the UI is full import with clean and commit.
> If I press the Execute button by mistake the whole index is cleaned
> without any notification.

I understand your frustration.  What I'm worried about is the fallout if
we change the default to be unchecked, from people who didn't verify the
setting and expected full-import to wipe their index before it started
importing, just like it has always done for the last few years.

The default value for the clean parameter when NOT using the admin UI is
true for full-import, and false for delta-import.  That's not going to
change.  I firmly believe that the admin UI should have the same
defaults as the API itself.  The very nature of a full-import carries
the implication that you want to start over with an empty index.

What if there were some bright red text in the UI near the execute
button that urged you to double-check that the "clean" box has the
setting you want?  An alternate idea would be to pop up a yes/no
verification dialog on execute when the clean box is checked.

Thanks,
Shawn

Re: Clean checkbox on DIH

[Alexandre Rafalovitch <ar...@gmail.com>]

Sounds like a good candidate for JIRA issue to me (maybe there is one
even?). Then people can vote, propose patches or offer alternative
solutions (e.g. a big exclamation mark or what not).


Regards,
   Alex.
----
http://www.solr-start.com/ - Resources for Solr users, new and experienced


On 28 April 2017 at 12:14, Vijay Kokatnur <ko...@gmail.com> wrote:
> Even though it's a minority, I think it should be disabled by default.
> That's a cleaner approach.  Accidentally running it in prod without
> unchecking 'clean' can be disastrous.
>
>
> On Apr 28, 2017, at 8:01AM, Mahmoud Almokadem <pr...@gmail.com>
> wrote:
>>
>> Thanks Shawn,
>>
>> We already using a shell scripts to do our import and using fullimport
>> command to do our delta import and everything is doing well several years
>> ago. But default of the UI is full import with clean and commit. If I press
>> the Execute button by mistake the whole index is cleaned without any
>> notification.
>>
>> Thanks,
>> Mahmoud
>>
>>
>>
>>
>> On Fri, Apr 28, 2017 at 2:51 PM, Shawn Heisey <ap...@elyograg.org> wrote:
>>
>>  On 4/28/2017 5:11 AM, Mahmoud Almokadem wrote:
>>>
>>>>  I'd like to request to uncheck the "Clean" checkbox by default on DIH
>>>>
>>>  page,
>>>
>>>>  cause it cleaned the whole index about 2TB when I click Execute button by
>>>>  wrong. Or show a confirmation message that the whole index will be
>>>>
>>>  cleaned!!
>>>
>>>  When somebody is doing a full-import, clean is what almost all users are
>>>  going to want.  If you're wanting to do full-import without cleaning,
>>>  then you are in the minority.  It is perhaps a fairly large minority,
>>>  but still not the majority.
>>>
>>>  Also, once you move into production, you should not be using the admin
>>>  UI for this.  You should be calling the DIH handler directly with HTTP
>>>  from another source, which might be a shell script using curl, or a
>>>  full-blown program in another language.
>>>
>>>  Thanks,
>>>  Shawn
>>
>>
>>
>>

Re: Clean checkbox on DIH

[Vijay Kokatnur <ko...@gmail.com>]

Even though it's a minority, I think it should be disabled by default.
​That's a cleaner approach.  Accidentally running it in prod without
unchecking 'clean' can be disastrous.


On Apr 28, 2017, at 8:01AM, Mahmoud Almokadem <pr...@gmail.com>
wrote:
>
> Thanks Shawn,
>
> We already using a shell scripts to do our import and using fullimport
> command to do our delta import and everything is doing well several years
> ago. But default of the UI is full import with clean and commit. If I press
> the Execute button by mistake the whole index is cleaned without any
> notification.
>
> Thanks,
> Mahmoud
>
>
>
>
> On Fri, Apr 28, 2017 at 2:51 PM, Shawn Heisey <ap...@elyograg.org> wrote:
>
>  On 4/28/2017 5:11 AM, Mahmoud Almokadem wrote:
>>
>>>  I'd like to request to uncheck the "Clean" checkbox by default on DIH
>>>
>>  page,
>>
>>>  cause it cleaned the whole index about 2TB when I click Execute button by
>>>  wrong. Or show a confirmation message that the whole index will be
>>>
>>  cleaned!!
>>
>>  When somebody is doing a full-import, clean is what almost all users are
>>  going to want.  If you're wanting to do full-import without cleaning,
>>  then you are in the minority.  It is perhaps a fairly large minority,
>>  but still not the majority.
>>
>>  Also, once you move into production, you should not be using the admin
>>  UI for this.  You should be calling the DIH handler directly with HTTP
>>  from another source, which might be a shell script using curl, or a
>>  full-blown program in another language.
>>
>>  Thanks,
>>  Shawn
>
>
>
>

Re: Clean checkbox on DIH

[Mahmoud Almokadem <pr...@gmail.com>]

Thanks Shawn,

We already using a shell scripts to do our import and using fullimport
command to do our delta import and everything is doing well several years
ago. But default of the UI is full import with clean and commit. If I press
the Execute button by mistake the whole index is cleaned without any
notification.

Thanks,
Mahmoud




On Fri, Apr 28, 2017 at 2:51 PM, Shawn Heisey <ap...@elyograg.org> wrote:

> On 4/28/2017 5:11 AM, Mahmoud Almokadem wrote:
> > I'd like to request to uncheck the "Clean" checkbox by default on DIH
> page,
> > cause it cleaned the whole index about 2TB when I click Execute button by
> > wrong. Or show a confirmation message that the whole index will be
> cleaned!!
>
> When somebody is doing a full-import, clean is what almost all users are
> going to want.  If you're wanting to do full-import without cleaning,
> then you are in the minority.  It is perhaps a fairly large minority,
> but still not the majority.
>
> Also, once you move into production, you should not be using the admin
> UI for this.  You should be calling the DIH handler directly with HTTP
> from another source, which might be a shell script using curl, or a
> full-blown program in another language.
>
> Thanks,
> Shawn
>
>

Re: Clean checkbox on DIH

[Shawn Heisey <ap...@elyograg.org>]

On 4/28/2017 5:11 AM, Mahmoud Almokadem wrote:
> I'd like to request to uncheck the "Clean" checkbox by default on DIH page,
> cause it cleaned the whole index about 2TB when I click Execute button by
> wrong. Or show a confirmation message that the whole index will be cleaned!!

When somebody is doing a full-import, clean is what almost all users are
going to want.  If you're wanting to do full-import without cleaning,
then you are in the minority.  It is perhaps a fairly large minority,
but still not the majority.

Also, once you move into production, you should not be using the admin
UI for this.  You should be calling the DIH handler directly with HTTP
from another source, which might be a shell script using curl, or a
full-blown program in another language.

Thanks,
Shawn