[GitHub] [buildstream] nanonyme commented on pull request #1447: Log exception if we hit invalid data rather than just failing

[GitBox <gi...@apache.org>]

nanonyme commented on pull request #1447:
URL: https://github.com/apache/buildstream/pull/1447#issuecomment-765333915


   Tries to provide better output in cases like
   ```
   ERROR:grpc._server:Exception calling application: [Errno 21] Is a directory: '/data/cas/objects/'
   Traceback (most recent call last):
     File "/usr/lib64/python3.7/site-packages/grpc/_server.py", line 406, in _call_behavior
       return behavior(argument, context), True
     File "/usr/local/lib/python3.7/site-packages/buildstream/_artifactcache/casserver.py", line 381, in GetReference
       self.cas.update_tree_mtime(tree)
     File "/usr/local/lib/python3.7/site-packages/buildstream/_artifactcache/cascache.py", line 638, in update_tree_mtime
       self._reachable_refs_dir(reachable, tree, update_mtime=True)
     File "/usr/local/lib/python3.7/site-packages/buildstream/_artifactcache/cascache.py", line 792, in _reachable_refs_dir
       with open(self.objpath(tree), 'rb') as f:
   IsADirectoryError: [Errno 21] Is a directory: '/data/cas/objects/'
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org