You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/19 20:13:14 UTC

[GitHub] [incubator-mxnet] ptrendx opened a new pull request #19378: Remove cleanup on side threads

ptrendx opened a new pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378


   ## Description ##
   Fixes #19360 
   
   @szha @mseth10 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19378: Remove cleanup on side threads

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378#issuecomment-712415396


   Hey @ptrendx , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, windows-gpu, unix-cpu, clang, centos-cpu, website, unix-gpu, sanity, windows-cpu, miscellaneous, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] szha merged pull request #19378: Remove cleanup on side threads

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] chinakook commented on pull request #19378: Remove cleanup on side threads

Posted by GitBox <gi...@apache.org>.
chinakook commented on pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378#issuecomment-730078762


   I'm sure that the ```train_faster_rcnn.py``` in gluon-cv will get weird error after this patch.
   ```terminate called after throwing an instance of 'dmlc::Error'
   terminate called recursively
     what():  [10:03:36] /home/xxxxx/mx/3rdparty/mshadow/mshadow/./stream_gpu-inl.h:192: Check failed: err == CUDNN_STATUS_SUCCESS (1 vs. 0) : CUDNN_STATUS_NOT_INITIALIZED```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #19378: Remove cleanup on side threads

Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378#discussion_r508850860



##########
File path: src/engine/naive_engine.cc
##########
@@ -75,13 +75,11 @@ class NaiveEngine final : public Engine {
     for (size_t i = 0; i < streams_.size(); ++i) {
       if (streams_[i] != nullptr) {
         // Catch exception for CUDA driver shutdown

Review comment:
       nit: remove comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19378: Remove cleanup on side threads

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378#issuecomment-713025235


   Jenkins CI successfully triggered : [miscellaneous, windows-cpu, centos-gpu, unix-gpu, centos-cpu, unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ptrendx commented on pull request #19378: Remove cleanup on side threads

Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #19378:
URL: https://github.com/apache/incubator-mxnet/pull/19378#issuecomment-713025187


   @mxnet-bot run ci [centos-cpu, centos-gpu, miscellaneous, unix-cpu, unix-gpu, windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org